From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4AtV-0006Fx-Pr for qemu-devel@nongnu.org; Wed, 22 Aug 2012 09:22:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4AtQ-0008ND-E8 for qemu-devel@nongnu.org; Wed, 22 Aug 2012 09:22:49 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:60359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4AtQ-0008N3-A1 for qemu-devel@nongnu.org; Wed, 22 Aug 2012 09:22:44 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 22 Aug 2012 09:22:43 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 1187A38C8042 for ; Wed, 22 Aug 2012 09:22:41 -0400 (EDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7MDMdkB191110 for ; Wed, 22 Aug 2012 09:22:39 -0400 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7MDMZVs010443 for ; Wed, 22 Aug 2012 07:22:35 -0600 From: Anthony Liguori In-Reply-To: <502F927A.8060709@redhat.com> References: <1345288635-1369-1-git-send-email-quintela@redhat.com> <1345288635-1369-4-git-send-email-quintela@redhat.com> <502F927A.8060709@redhat.com> Date: Wed, 22 Aug 2012 08:22:19 -0500 Message-ID: <87wr0rgiyc.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move total_time from ram stats to migration info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Juan Quintela Cc: qemu-devel@nongnu.org Eric Blake writes: > On 08/18/2012 05:17 AM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> hmp.c | 4 ++-- >> migration.c | 6 +++--- >> qapi-schema.json | 14 +++++++------- >> qmp-commands.hx | 6 +++--- >> 4 files changed, 15 insertions(+), 15 deletions(-) >> > >> +++ b/qapi-schema.json >> @@ -290,10 +290,6 @@ >> # >> # @total: total amount of bytes involved in the migration process >> # >> -# @total-time: total amount of ms since migration started. If >> -# migration has ended, it returns the total migration >> -# time. (since 1.2) >> -# >> # @duplicate: number of duplicate pages (since 1.2) >> # >> # @normal : number of normal pages (since 1.2) >> @@ -304,8 +300,7 @@ >> ## >> { 'type': 'MigrationStats', >> 'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' , >> - 'total-time': 'int', 'duplicate': 'int', 'normal': 'int', >> - 'normal-bytes': 'int' } } >> + 'duplicate': 'int', 'normal': 'int', 'normal-bytes': 'int' } } >> >> ## >> # @XBZRLECacheStats >> @@ -350,12 +345,17 @@ >> # migration statistics, only returned if XBZRLE feature is on and >> # status is 'active' or 'completed' (since 1.2) >> # >> +# @total-time: total amount of milliseconds since migration started. >> +# If migration has ended, it returns the total migration >> +# time. (since 1.2) >> +# >> # Since: 0.14.0 >> ## >> { 'type': 'MigrationInfo', >> 'data': {'*status': 'str', '*ram': 'MigrationStats', >> '*disk': 'MigrationStats', >> - '*xbzrle-cache': 'XBZRLECacheStats'} } >> + '*xbzrle-cache': 'XBZRLECacheStats', >> + 'total-time': 'int'} } > > Anthony - are you planning on taking this series for 1.2? No. This is a new feature and we're past freeze. > If we don't > get this patch in on time, then taking this for 1.3 would result in > changing released QMP interface (right now, there has been no release > with the field in the wrong type). Ack. We need to preserve compat with the 1.2 interface. Regards, Anthony Liguori > > -- > Eric Blake eblake@redhat.com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org