From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57410)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1RIDpv-0005KP-E9
	for qemu-devel@nongnu.org; Mon, 24 Oct 2011 02:16:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1RIDpt-00015M-V6
	for qemu-devel@nongnu.org; Mon, 24 Oct 2011 02:16:39 -0400
Received: from e1.ny.us.ibm.com ([32.97.182.141]:45280)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1RIDpt-00015D-RO
	for qemu-devel@nongnu.org; Mon, 24 Oct 2011 02:16:37 -0400
Received: from /spool/local
	by e1.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aneesh.kumar@linux.vnet.ibm.com>;
	Mon, 24 Oct 2011 02:16:34 -0400
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p9O6GWMB252812
	for <qemu-devel@nongnu.org>; Mon, 24 Oct 2011 02:16:32 -0400
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p9O6GV0R017723
	for <qemu-devel@nongnu.org>; Mon, 24 Oct 2011 00:16:31 -0600
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <4EA41CB3.9060405@web.de>
References: <201110202320.54504.jcmvbkbc@gmail.com>
	<87y5we4byh.fsf@linux.vnet.ibm.com> <4EA41CB3.9060405@web.de>
Date: Mon, 24 Oct 2011 11:46:21 +0530
Message-ID: <87wrbuud6y.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] build with trace enabled is broken by the commit
	c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce
	tracing for 9p pdu handlers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Max Filippov <jcmvbkbc@gmail.com>, Harsh Prateek Bora <harsh@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On Sun, 23 Oct 2011 15:54:59 +0200, Jan Kiszka <jan.kiszka@web.de> wrote:
> On 2011-10-21 17:10, Aneesh Kumar K.V wrote:
> > On Thu, 20 Oct 2011 23:20:54 +0400, Max Filippov <jcmvbkbc@gmail.com> w=
rote:
> >> Hi.
> >>
> >> Current git head build with trace enabled is broken by the commit c572=
f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu =
handlers.
> >> Error messages:
> >>
> >> In file included from trace.c:2:0:
> >> trace.h: In function =E2=80=98trace_v9fs_attach=E2=80=99:
> >> trace.h:2850:9: error: too many arguments for format [-Werror=3Dformat=
-extra-args]
> >> trace.h: In function =E2=80=98trace_v9fs_wstat=E2=80=99:
> >> trace.h:3039:9: error: too many arguments for format [-Werror=3Dformat=
-extra-args]
> >> trace.h: In function =E2=80=98trace_v9fs_mkdir=E2=80=99:
> >> trace.h:3088:9: error: too many arguments for format [-Werror=3Dformat=
-extra-args]
> >> trace.h: In function =E2=80=98trace_v9fs_mkdir_return=E2=80=99:
> >> trace.h:3095:9: error: too many arguments for format [-Werror=3Dformat=
-extra-args]
> >> cc1: all warnings being treated as errors
> >>
> >> Prototypes in the trace-events do not match format strings, e.g.
> >>
> >> v9fs_attach(uint16_t tag, uint8_t id, int32_t fid, int32_t afid, char*=
 uname, char* aname) "tag %d id %d fid %d afid %d aname %s"
> >>
> >> The following patch fixes it, but I'm not sure the format lines are ap=
propriate.
> >=20
> > Can you send the patch with signed-off-by: I will add it in the next
> > pull request.
>=20
> There are more breakages with tracing enabled:
>=20
>   CC    libhw64/9pfs/virtio-9p.o
> cc1: warnings being treated as errors
> /data/qemu/hw/9pfs/virtio-9p.c: In function =E2=80=98v9fs_create=E2=80=99:
> /data/qemu/hw/9pfs/virtio-9p.c:2225:9: error: =E2=80=98iounit=E2=80=99 ma=
y be used uninitialized in this function=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20
> /data/qemu/hw/9pfs/virtio-9p.c: In function =E2=80=98v9fs_readdir=E2=80=
=99:
> /data/qemu/hw/9pfs/virtio-9p.c:2063:13: error: =E2=80=98count=E2=80=99 ma=
y be used uninitialized in this function=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20
> /data/qemu/hw/9pfs/virtio-9p.c: In function =E2=80=98v9fs_xattrwalk=E2=80=
=99:
> /data/qemu/hw/9pfs/virtio-9p.c:3103:13: error: =E2=80=98size=E2=80=99 may=
 be used uninitialized in this function=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20
> /data/qemu/hw/9pfs/virtio-9p.c: In function =E2=80=98v9fs_lcreate=E2=80=
=99:
> /data/qemu/hw/9pfs/virtio-9p.c:1730:13: error: =E2=80=98iounit=E2=80=99 m=
ay be used uninitialized in this function=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20
> /data/qemu/hw/9pfs/virtio-9p.c: In function =E2=80=98v9fs_open=E2=80=99:
> /data/qemu/hw/9pfs/virtio-9p.c:1651:9: error: =E2=80=98iounit=E2=80=99 ma=
y be used uninitialized in this function=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20
>=20
> Not sure what the undefined variables are supposed to contain for the
> trace output, so I refrain from writing any patch.

Ok i am testing VirtFS tracing and will send a patch that should fix these
issues. Sorry for all inconvenience. Even though i do test on
three different distros, all of them were done without tracing enabled.

-aneesh