* [PATCH v2] migration: Don't free the reason after calling migrate_add_blocker
@ 2025-10-24 20:55 Bin Guo
2025-10-27 5:31 ` Markus Armbruster
2025-10-28 14:37 ` Peter Xu
0 siblings, 2 replies; 3+ messages in thread
From: Bin Guo @ 2025-10-24 20:55 UTC (permalink / raw)
To: qemu-devel; +Cc: peterx, farosas, armbru, berrange
Function migrate_add_blocker will free the reason and set it to NULL
if failure is returned.
Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
---
hw/intc/arm_gicv3_kvm.c | 1 -
target/i386/sev.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
index 66b0dddfd4..6f311e37ef 100644
--- a/hw/intc/arm_gicv3_kvm.c
+++ b/hw/intc/arm_gicv3_kvm.c
@@ -841,7 +841,6 @@ static void kvm_arm_gicv3_realize(DeviceState *dev, Error **errp)
error_setg(&kvm_nv_migration_blocker,
"Live migration disabled because KVM nested virt is enabled");
if (migrate_add_blocker(&kvm_nv_migration_blocker, errp)) {
- error_free(kvm_nv_migration_blocker);
return;
}
diff --git a/target/i386/sev.c b/target/i386/sev.c
index 1057b8ab2c..fd2dada013 100644
--- a/target/i386/sev.c
+++ b/target/i386/sev.c
@@ -1661,7 +1661,6 @@ sev_snp_launch_finish(SevCommonState *sev_common)
ret = migrate_add_blocker(&sev_mig_blocker, &local_err);
if (local_err) {
error_report_err(local_err);
- error_free(sev_mig_blocker);
exit(1);
}
}
--
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] migration: Don't free the reason after calling migrate_add_blocker
2025-10-24 20:55 [PATCH v2] migration: Don't free the reason after calling migrate_add_blocker Bin Guo
@ 2025-10-27 5:31 ` Markus Armbruster
2025-10-28 14:37 ` Peter Xu
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2025-10-27 5:31 UTC (permalink / raw)
To: Bin Guo; +Cc: qemu-devel, peterx, farosas, berrange
Bin Guo <guobin@linux.alibaba.com> writes:
> Function migrate_add_blocker will free the reason and set it to NULL
> if failure is returned.
>
> Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
> ---
> hw/intc/arm_gicv3_kvm.c | 1 -
> target/i386/sev.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
> index 66b0dddfd4..6f311e37ef 100644
> --- a/hw/intc/arm_gicv3_kvm.c
> +++ b/hw/intc/arm_gicv3_kvm.c
> @@ -841,7 +841,6 @@ static void kvm_arm_gicv3_realize(DeviceState *dev, Error **errp)
> error_setg(&kvm_nv_migration_blocker,
> "Live migration disabled because KVM nested virt is enabled");
> if (migrate_add_blocker(&kvm_nv_migration_blocker, errp)) {
> - error_free(kvm_nv_migration_blocker);
> return;
> }
>
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index 1057b8ab2c..fd2dada013 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -1661,7 +1661,6 @@ sev_snp_launch_finish(SevCommonState *sev_common)
> ret = migrate_add_blocker(&sev_mig_blocker, &local_err);
> if (local_err) {
> error_report_err(local_err);
> - error_free(sev_mig_blocker);
> exit(1);
> }
> }
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] migration: Don't free the reason after calling migrate_add_blocker
2025-10-24 20:55 [PATCH v2] migration: Don't free the reason after calling migrate_add_blocker Bin Guo
2025-10-27 5:31 ` Markus Armbruster
@ 2025-10-28 14:37 ` Peter Xu
1 sibling, 0 replies; 3+ messages in thread
From: Peter Xu @ 2025-10-28 14:37 UTC (permalink / raw)
To: Bin Guo; +Cc: qemu-devel, farosas, armbru, berrange
On Sat, Oct 25, 2025 at 04:55:32AM +0800, Bin Guo wrote:
> Function migrate_add_blocker will free the reason and set it to NULL
> if failure is returned.
>
> Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
queued, thanks.
> ---
> hw/intc/arm_gicv3_kvm.c | 1 -
> target/i386/sev.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
> index 66b0dddfd4..6f311e37ef 100644
> --- a/hw/intc/arm_gicv3_kvm.c
> +++ b/hw/intc/arm_gicv3_kvm.c
> @@ -841,7 +841,6 @@ static void kvm_arm_gicv3_realize(DeviceState *dev, Error **errp)
> error_setg(&kvm_nv_migration_blocker,
> "Live migration disabled because KVM nested virt is enabled");
> if (migrate_add_blocker(&kvm_nv_migration_blocker, errp)) {
> - error_free(kvm_nv_migration_blocker);
> return;
> }
>
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index 1057b8ab2c..fd2dada013 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -1661,7 +1661,6 @@ sev_snp_launch_finish(SevCommonState *sev_common)
> ret = migrate_add_blocker(&sev_mig_blocker, &local_err);
> if (local_err) {
> error_report_err(local_err);
> - error_free(sev_mig_blocker);
> exit(1);
> }
> }
> --
>
--
Peter Xu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-28 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-24 20:55 [PATCH v2] migration: Don't free the reason after calling migrate_add_blocker Bin Guo
2025-10-27 5:31 ` Markus Armbruster
2025-10-28 14:37 ` Peter Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).