qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] qapi/char.json: minor doc rewording for `hub` device
@ 2025-02-19  9:06 Roman Penyaev
  2025-02-19 13:24 ` Markus Armbruster
  0 siblings, 1 reply; 4+ messages in thread
From: Roman Penyaev @ 2025-02-19  9:06 UTC (permalink / raw)
  Cc: Roman Penyaev, Marc-André Lureau, Markus Armbruster,
	qemu-devel

Refine documentation for the hub device, specify the maximum.

Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
---
 qapi/char.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qapi/char.json b/qapi/char.json
index f02b66c06b3e..dde2f9538f81 100644
--- a/qapi/char.json
+++ b/qapi/char.json
@@ -337,7 +337,7 @@
 #
 # Configuration info for hub chardevs.
 #
-# @chardevs: List of chardev IDs, which should be added to this hub
+# @chardevs: IDs to be added to this hub (maximum 4 devices).
 #
 # Since: 10.0
 ##
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] qapi/char.json: minor doc rewording for `hub` device
  2025-02-19  9:06 [PATCH 1/1] qapi/char.json: minor doc rewording for `hub` device Roman Penyaev
@ 2025-02-19 13:24 ` Markus Armbruster
  2025-02-26  8:02   ` Roman Penyaev
  0 siblings, 1 reply; 4+ messages in thread
From: Markus Armbruster @ 2025-02-19 13:24 UTC (permalink / raw)
  To: Roman Penyaev; +Cc: Marc-André Lureau, qemu-devel

Roman Penyaev <r.peniaev@gmail.com> writes:

> Refine documentation for the hub device, specify the maximum.
>
> Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
>  qapi/char.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/char.json b/qapi/char.json
> index f02b66c06b3e..dde2f9538f81 100644
> --- a/qapi/char.json
> +++ b/qapi/char.json
> @@ -337,7 +337,7 @@
>  #
>  # Configuration info for hub chardevs.
>  #
> -# @chardevs: List of chardev IDs, which should be added to this hub
> +# @chardevs: IDs to be added to this hub (maximum 4 devices).
>  #
>  # Since: 10.0
>  ##

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Thank you, Roman!



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] qapi/char.json: minor doc rewording for `hub` device
  2025-02-19 13:24 ` Markus Armbruster
@ 2025-02-26  8:02   ` Roman Penyaev
  2025-02-26  8:49     ` Markus Armbruster
  0 siblings, 1 reply; 4+ messages in thread
From: Roman Penyaev @ 2025-02-26  8:02 UTC (permalink / raw)
  To: Markus Armbruster; +Cc: Marc-André Lureau, qemu-devel

Hi Marc-Andre,

If you don't have objections to this one small doc change,
could you please pull the change?

Thanks.

--
Roman

On Wed, Feb 19, 2025 at 2:24 PM Markus Armbruster <armbru@redhat.com> wrote:
>
> Roman Penyaev <r.peniaev@gmail.com> writes:
>
> > Refine documentation for the hub device, specify the maximum.
> >
> > Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
> > Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> > Cc: Markus Armbruster <armbru@redhat.com>
> > Cc: qemu-devel@nongnu.org
> > ---
> >  qapi/char.json | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/qapi/char.json b/qapi/char.json
> > index f02b66c06b3e..dde2f9538f81 100644
> > --- a/qapi/char.json
> > +++ b/qapi/char.json
> > @@ -337,7 +337,7 @@
> >  #
> >  # Configuration info for hub chardevs.
> >  #
> > -# @chardevs: List of chardev IDs, which should be added to this hub
> > +# @chardevs: IDs to be added to this hub (maximum 4 devices).
> >  #
> >  # Since: 10.0
> >  ##
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> Thank you, Roman!
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] qapi/char.json: minor doc rewording for `hub` device
  2025-02-26  8:02   ` Roman Penyaev
@ 2025-02-26  8:49     ` Markus Armbruster
  0 siblings, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2025-02-26  8:49 UTC (permalink / raw)
  To: Roman Penyaev; +Cc: Marc-André Lureau, qemu-devel

Roman Penyaev <r.peniaev@gmail.com> writes:

> Hi Marc-Andre,
>
> If you don't have objections to this one small doc change,
> could you please pull the change?

I'm working on a pull request, and I'm happy to include this patch.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-02-26  8:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-19  9:06 [PATCH 1/1] qapi/char.json: minor doc rewording for `hub` device Roman Penyaev
2025-02-19 13:24 ` Markus Armbruster
2025-02-26  8:02   ` Roman Penyaev
2025-02-26  8:49     ` Markus Armbruster

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).