From: Fabiano Rosas <farosas@suse.de>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Hyman Huang" <yong.huang@smartx.com>,
"Phil Dennis-Jordan" <phil@philjordan.eu>,
"Peter Xu" <peterx@redhat.com>,
"Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH 1/7] migration/dirtyrate: Do not unlock cpu_list lock twice
Date: Tue, 28 Jan 2025 11:27:01 -0300 [thread overview]
Message-ID: <87y0yvt3nu.fsf@suse.de> (raw)
In-Reply-To: <20250128135429.8500-2-philmd@linaro.org>
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> &qemu_cpu_list_lock is locked within the WITH_QEMU_LOCK_GUARD()
> context, then unlocked. No need to manually unlock it.
>
> Fixes: 370ed600296 ("cpu: expose qemu_cpu_list_lock for lock-guard use")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> migration/dirtyrate.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index 7c955894e47..4b94dd7c500 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -174,7 +174,6 @@ retry:
> if (gen_id != cpu_list_generation_id_get()) {
> g_free(records);
> g_free(stat->rates);
> - cpu_list_unlock();
> goto retry;
> }
> vcpu_dirty_stat_collect(records, false);
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2025-01-28 14:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 13:54 [PATCH 0/7] tests/qtest/migration: Update framework to allow using HVF accelerator Philippe Mathieu-Daudé
2025-01-28 13:54 ` [PATCH 1/7] migration/dirtyrate: Do not unlock cpu_list lock twice Philippe Mathieu-Daudé
2025-01-28 14:27 ` Fabiano Rosas [this message]
2025-01-28 19:16 ` Richard Henderson
2025-01-28 13:54 ` [PATCH 2/7] tests/qtest/migration: Make 'has_dirty_ring' generic Philippe Mathieu-Daudé
2025-01-28 14:29 ` Fabiano Rosas
2025-01-28 13:54 ` [PATCH 3/7] tests/qtest/migration: Initialize MigrationTestEnv::arch early Philippe Mathieu-Daudé
2025-01-28 14:43 ` Fabiano Rosas
2025-01-28 19:20 ` Richard Henderson
2025-01-28 13:54 ` [PATCH 4/7] tests/qtest/migration: Pass accelerator arguments as machine option Philippe Mathieu-Daudé
2025-01-28 14:59 ` Fabiano Rosas
2025-01-28 19:24 ` Richard Henderson
2025-01-28 13:54 ` [PATCH 5/7] tests/qtest/migration: Add MigrationTestEnv::has_hvf field Philippe Mathieu-Daudé
2025-01-28 15:00 ` Fabiano Rosas
2025-01-28 19:25 ` Richard Henderson
2025-01-28 13:54 ` [RFC PATCH 6/7] tests/qtest/migration: Run aarch64/HVF tests using GICv2 Philippe Mathieu-Daudé
2025-01-29 5:39 ` Akihiko Odaki
2025-02-09 19:02 ` Phil Dennis-Jordan
2025-01-28 13:54 ` [PATCH 7/7] tests/qtest/migration: Allow using accelerators different of TCG / KVM Philippe Mathieu-Daudé
2025-01-28 15:04 ` Fabiano Rosas
2025-01-28 19:29 ` Richard Henderson
2025-01-28 19:50 ` Fabiano Rosas
2025-01-28 21:08 ` Richard Henderson
2025-01-28 19:26 ` Richard Henderson
2025-01-28 13:55 ` [PATCH 0/7] tests/qtest/migration: Update framework to allow using HVF accelerator Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0yvt3nu.fsf@suse.de \
--to=farosas@suse.de \
--cc=akihiko.odaki@daynix.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=phil@philjordan.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=yong.huang@smartx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).