From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A7EEC47258 for ; Tue, 23 Jan 2024 19:08:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSM7P-00077H-T7; Tue, 23 Jan 2024 14:07:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSM7H-00076k-9d for qemu-devel@nongnu.org; Tue, 23 Jan 2024 14:07:24 -0500 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSM7F-0007A0-L4 for qemu-devel@nongnu.org; Tue, 23 Jan 2024 14:07:23 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BF54422291; Tue, 23 Jan 2024 19:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706036836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K4AD7aOoTVmyy3oDuFcAZRfpuZ/XBCXs8IHQYYlFaes=; b=Dhsp2VOnvRZJUMXTckB99VFDx2qN2O+G8WZ+aP+gsIIkRED8/VgBrmuovG5DnsOk5zzEAu xg/j1ROdA3Ldb0ZznCPfPPxT7AuKyYqOgJ+z6LbHOHhYwBBhjQd302Jv1ffGCe5ZM1V7I8 uEL+gkvZZmdVhzWPXvfyFAZ5g8yDebM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706036836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K4AD7aOoTVmyy3oDuFcAZRfpuZ/XBCXs8IHQYYlFaes=; b=M69MrDyvJGz2ef8z2vkJdjbvxiQu7b0SoOhDCDW1qUin0qoI8rA9pZap7OMBFdYfLhJtFj TPHix2A5gVDRkaCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706036835; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K4AD7aOoTVmyy3oDuFcAZRfpuZ/XBCXs8IHQYYlFaes=; b=pOXfnmbKmHKdoIVHocPEo2vmZlLkSYyO/kGfEYJqWBtULBQJ9ZGtHr4adLyZDfS3XVDZzx Dh/gGtSOPiAozryGJyKJf85crBGgShYZvEjGURevL8pJJlP/2EY5x69fskfxxz6yNeF9Yp c1Ge/cAZFvd4Q5TT8D6C4zLeuPSJsH8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706036835; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K4AD7aOoTVmyy3oDuFcAZRfpuZ/XBCXs8IHQYYlFaes=; b=NtMdp6bQQUSoEOPQYVKhDdfKGWytEQd9tHlhdf2FcHts7Qc2+tiLYA/bgo1i98ZOc5QGdC DjFL8Wluzr+8wnDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4860A13786; Tue, 23 Jan 2024 19:07:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1fJWBGMOsGWSOwAAD6G6ig (envelope-from ); Tue, 23 Jan 2024 19:07:15 +0000 From: Fabiano Rosas To: Peter Xu Cc: qemu-devel@nongnu.org, berrange@redhat.com, armbru@redhat.com, Juan Quintela , Leonardo Bras , Claudio Fontana Subject: Re: [RFC PATCH v3 07/30] migration: Add fixed-ram URI compatibility check In-Reply-To: References: <20231127202612.23012-1-farosas@suse.de> <20231127202612.23012-8-farosas@suse.de> Date: Tue, 23 Jan 2024 16:07:12 -0300 Message-ID: <87y1cfeun3.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=pOXfnmbK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=NtMdp6bQ X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-6.51 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; BAYES_HAM(-3.00)[100.00%]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[7]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Rspamd-Queue-Id: BF54422291 Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > On Mon, Nov 27, 2023 at 05:25:49PM -0300, Fabiano Rosas wrote: >> The fixed-ram migration format needs a channel that supports seeking >> to be able to write each page to an arbitrary offset in the migration >> stream. >>=20 >> Signed-off-by: Fabiano Rosas >> Reviewed-by: Daniel P. Berrang=C3=A9 >> --- >> - avoided overwriting errp in compatibility check >> --- >> migration/migration.c | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >>=20 >> diff --git a/migration/migration.c b/migration/migration.c >> index 28a34c9068..897ed1db67 100644 >> --- a/migration/migration.c >> +++ b/migration/migration.c >> @@ -135,10 +135,26 @@ static bool transport_supports_multi_channels(Sock= etAddress *saddr) >> saddr->type =3D=3D SOCKET_ADDRESS_TYPE_VSOCK; >> } >>=20=20 >> +static bool migration_needs_seekable_channel(void) >> +{ >> + return migrate_fixed_ram(); >> +} >> + >> +static bool transport_supports_seeking(MigrationAddress *addr) >> +{ >> + return addr->transport =3D=3D MIGRATION_ADDRESS_TYPE_FILE; >> +} > > What about TYPE_FD? Is it going to be supported later? > nSorry, I missed this one. Yes, and thanks for asking because I just remembered I have code for this lost in a git stash somewhere. I'll include it in v4. >> + >> static bool >> migration_channels_and_transport_compatible(MigrationAddress *addr, >> Error **errp) >> { >> + if (migration_needs_seekable_channel() && >> + !transport_supports_seeking(addr)) { >> + error_setg(errp, "Migration requires seekable transport (e.g. f= ile)"); >> + return false; >> + } >> + >> if (migration_needs_multiple_sockets() && >> (addr->transport =3D=3D MIGRATION_ADDRESS_TYPE_SOCKET) && >> !transport_supports_multi_channels(&addr->u.socket)) { >> --=20 >> 2.35.3 >>=20