From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65DBFCDB465 for ; Thu, 19 Oct 2023 12:41:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtSKG-0008HA-Qb; Thu, 19 Oct 2023 08:40:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtSKE-0008GK-HJ for qemu-devel@nongnu.org; Thu, 19 Oct 2023 08:40:30 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtSKB-0002nR-9V for qemu-devel@nongnu.org; Thu, 19 Oct 2023 08:40:30 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c514cbbe7eso74568481fa.1 for ; Thu, 19 Oct 2023 05:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697719225; x=1698324025; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=/8+ZGXg3QALhBBYt5SOXOpRYBAi+zfA4xfcRwbZuMII=; b=UAMaWJO6+ngZfH8XxCK+3/30/CvUZsgqBLUU5QyPwykrVtJHqyKHPJveD6YV1msfza Wo1VlVBdiqCz/bGqfe+i7haMOrB3H635wZQdiU1EufaU/kqIZ9EERIHU24CnGLbPeoi8 IY0reIPhc9opLWxro0KCQ/4XBOu5X8B5l0tcUBk5k1+9ektD/eim4/t7vvM56IV0yc1s Sm78MzHwPRn2j2QS2xq+Ow3LU7hePCyN6hQ/2mnbI7DoyUzUMZHnJAmOVaGIuw+iBahk vtJRpRdJS0NYhTmWhpfcSO2aJJGw55IH1NqlWRpfzqpcSFKYiIEoTNdZkFTb4DHgpKzQ Lc9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697719225; x=1698324025; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/8+ZGXg3QALhBBYt5SOXOpRYBAi+zfA4xfcRwbZuMII=; b=t/qJuzhszFwc4vqqNUHFxgNi5lzsGLvLZ0wMXltdD7H4nc+FcRV9vtjU7zNDAmXRcX SnsBj8D0fWfirYP48zjl2FzEYqXJkb2nthPm1HhhbNFwuOGqinM/flptirHVR9zEz571 /BxgOBOJsCOIHFE64su1eO1h2G1EBcrYbt9dH1zBYpE+t9ily2P0O+Wf2DW0LWyTe4rF uVo7OUzKucXp9WzNQo/xlLgGrzP7kdi7C6/1wbEpJc195odHymPVDoxqXD57MW+pkOmk XmxVuT2iR2xxrBX8tZjvgMVmOXo57CqE3nXlTxhON0dl28KPVi91/+p+VBkbPiBMJv/4 zY/g== X-Gm-Message-State: AOJu0YwHeLc2MNfXQuuV1xA9TdChS7wFG9OPy274ADpnEm1sdDoQGC0o VEQw0DvJjptj6NnlMus5i4kDnQ== X-Google-Smtp-Source: AGHT+IHMr7gnoSTks9bWnl4MgCTmg9A7wTTknuUMeebWWrCjX3qlPGTuV6JKMnto2A285fiFXxyWng== X-Received: by 2002:a2e:8654:0:b0:2c0:52e:eafa with SMTP id i20-20020a2e8654000000b002c0052eeafamr1594579ljj.29.1697719225496; Thu, 19 Oct 2023 05:40:25 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id v11-20020a5d590b000000b003247d3e5d99sm4405132wrd.55.2023.10.19.05.40.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 05:40:25 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A1ACC1FFBB; Thu, 19 Oct 2023 13:40:24 +0100 (BST) References: <20230731091042.139159-1-akihiko.odaki@daynix.com> <20230731091042.139159-3-akihiko.odaki@daynix.com> <8df33f0f-c394-5eb8-ca0c-5601790745f8@redhat.com> User-agent: mu4e 1.11.22; emacs 29.1.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Thomas Huth Cc: Akihiko Odaki , Christian Borntraeger , Juan Quintela , Peter Xu , Leonardo Bras , Peter Maydell , Richard Henderson , "Edgar E . Iglesias" , Brian Cain , Paolo Bonzini , Eduardo Habkost , Song Gao , Xiaojuan Yang , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Aleksandar Rikalo , Chris Wulff , Marek Vasut , David Hildenbrand , Ilya Leoshkevich , qemu-devel@nongnu.org, qemu-s390x@nongnu.org, qemu-arm@nongnu.org Subject: Re: [PATCH v2 2/2] tests/tcg: Add -fno-stack-protector Date: Thu, 19 Oct 2023 13:40:06 +0100 In-reply-to: <8df33f0f-c394-5eb8-ca0c-5601790745f8@redhat.com> Message-ID: <87y1fy945j.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::22b; envelope-from=alex.bennee@linaro.org; helo=mail-lj1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Thomas Huth writes: > On 31/07/2023 11.10, Akihiko Odaki wrote: >> A build of GCC 13.2 will have stack protector enabled by default if it >> was configured with --enable-default-ssp option. For such a compiler, >> it is necessary to explicitly disable stack protector when linking >> without standard libraries. >> Signed-off-by: Akihiko Odaki >> --- >> tests/tcg/mips/hello-mips.c | 4 ++-- >> tests/tcg/Makefile.target | 2 +- >> tests/tcg/aarch64/Makefile.target | 2 +- >> tests/tcg/arm/Makefile.target | 2 +- >> tests/tcg/cris/Makefile.target | 2 +- >> tests/tcg/hexagon/Makefile.target | 2 +- >> tests/tcg/i386/Makefile.target | 2 +- >> tests/tcg/minilib/Makefile.target | 2 +- >> tests/tcg/mips/Makefile.target | 2 +- >> 9 files changed, 10 insertions(+), 10 deletions(-) >> diff --git a/tests/tcg/mips/hello-mips.c >> b/tests/tcg/mips/hello-mips.c >> index 4e1cf501af..0ba5f1bf23 100644 >> --- a/tests/tcg/mips/hello-mips.c >> +++ b/tests/tcg/mips/hello-mips.c >> @@ -5,8 +5,8 @@ >> * http://www.linux-mips.org/wiki/MIPSABIHistory >> * http://www.linux.com/howtos/Assembly-HOWTO/mips.shtml >> * >> -* mipsel-linux-gcc -nostdlib -mno-abicalls -fno-PIC -mabi=3D32 \ >> -* -O2 -static -o hello-mips hello-mips.c >> +* mipsel-linux-gcc -nostdlib -mno-abicalls -fno-PIC -fno-stack-protecto= r \ >> + -mabi=3D32 -O2 -static -o hello-mips hello-mips.c > > You've lost the "*" at the beginning of the comment line here. > > But apart from that nit, the patch looks sane to me. > > Cc:-ing Alex Benn=C3=A9e ... could pick this patch up? Queued to testing/next with tweak to comment, thanks. --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro