From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>,
peter.maydell@linaro.org, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, quic_tsoni@quicinc.com,
quic_pheragu@quicinc.com, quic_eberman@quicinc.com,
quic_yvasi@quicinc.com, quic_cvanscha@quicinc.com,
quic_mnalajal@quicinc.com
Subject: Re: [RFC/PATCH v0 03/12] gunyah: Basic support
Date: Thu, 12 Oct 2023 12:32:34 +0100 [thread overview]
Message-ID: <87y1g8m5pd.fsf@linaro.org> (raw)
In-Reply-To: <d4814468-3b1c-ea34-563e-9418bf1d6220@linaro.org>
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> Hi Srivatsa,
>
> On 11/10/23 18:52, Srivatsa Vaddagiri wrote:
>> Add a new accelerator, gunyah, with basic functionality of creating a
>> VM. Subsequent patches will add support for other functions required to
>> run a VM.
>> Signed-off-by: Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>
>> ---
>> MAINTAINERS | 7 +++
>> accel/Kconfig | 3 +
>> accel/gunyah/gunyah-accel-ops.c | 102 ++++++++++++++++++++++++++++++++
>> accel/gunyah/gunyah-all.c | 70 ++++++++++++++++++++++
>> accel/gunyah/meson.build | 7 +++
>> accel/meson.build | 1 +
>> accel/stubs/gunyah-stub.c | 13 ++++
>> accel/stubs/meson.build | 1 +
>> docs/about/build-platforms.rst | 2 +-
>> hw/arm/virt.c | 3 +
>> include/sysemu/gunyah.h | 43 ++++++++++++++
>> include/sysemu/gunyah_int.h | 27 +++++++++
>> meson.build | 9 +++
>> meson_options.txt | 2 +
>> scripts/meson-buildoptions.sh | 3 +
>> target/arm/cpu64.c | 5 +-
>> 16 files changed, 295 insertions(+), 3 deletions(-)
>> create mode 100644 accel/gunyah/gunyah-accel-ops.c
>> create mode 100644 accel/gunyah/gunyah-all.c
>> create mode 100644 accel/gunyah/meson.build
>> create mode 100644 accel/stubs/gunyah-stub.c
>> create mode 100644 include/sysemu/gunyah.h
>> create mode 100644 include/sysemu/gunyah_int.h
>
> Can we move gunyah_int.h to accel/gunyah/?
If it's all internal to gunyah itself you could rename it to internal.h
(although we do have various forms of foo-internal.h across the code
base).
However I see the reason is the other accelerators have done so:
accel/hvf/hvf-accel-ops.c
58:#include "sysemu/hvf_int.h"
accel/hvf/hvf-all.c
14:#include "sysemu/hvf_int.h"
accel/kvm/kvm-accel-ops.c
20:#include "sysemu/kvm_int.h"
accel/kvm/kvm-all.c
31:#include "sysemu/kvm_int.h"
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-10-12 11:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 16:52 [RFC/PATCH v0 00/12] Gunyah hypervisor support Srivatsa Vaddagiri
2023-10-11 16:52 ` [RFC/PATCH v0 01/12] hw/arm/virt: Avoid NULL pointer de-reference Srivatsa Vaddagiri
2023-10-12 4:30 ` Philippe Mathieu-Daudé
2023-10-12 5:02 ` Markus Armbruster
2023-10-12 12:24 ` Srivatsa Vaddagiri
2023-10-11 16:52 ` [RFC/PATCH v0 02/12] update-linux-headers: Include gunyah.h Srivatsa Vaddagiri
2023-10-11 16:57 ` Srivatsa Vaddagiri
2023-11-29 16:44 ` Alex Bennée
2023-12-01 10:35 ` Srivatsa Vaddagiri
2023-10-11 16:52 ` [RFC/PATCH v0 03/12] gunyah: Basic support Srivatsa Vaddagiri
2023-10-12 4:33 ` Philippe Mathieu-Daudé
2023-10-12 11:32 ` Alex Bennée [this message]
2023-10-12 12:24 ` Srivatsa Vaddagiri
2023-11-29 16:56 ` Alex Bennée
2023-12-01 10:33 ` Srivatsa Vaddagiri
2023-10-11 16:52 ` [RFC/PATCH v0 04/12] gunyah: Add VM properties Srivatsa Vaddagiri
2023-10-11 16:52 ` [RFC/PATCH v0 05/12] gunyah: Support memory assignment Srivatsa Vaddagiri
2023-10-11 16:52 ` [RFC/PATCH v0 06/12] gunyah: Add IRQFD and IOEVENTFD functions Srivatsa Vaddagiri
2023-10-11 16:52 ` [RFC/PATCH v0 07/12] gunyah: Add gicv3 interrupt controller Srivatsa Vaddagiri
2023-10-11 16:52 ` [RFC/PATCH v0 08/12] gunyah: Specific device-tree location Srivatsa Vaddagiri
2023-10-12 4:35 ` Philippe Mathieu-Daudé
2023-10-11 16:52 ` [RFC/PATCH v0 09/12] gunyah: Customize device-tree Srivatsa Vaddagiri
2023-10-12 4:36 ` Philippe Mathieu-Daudé
2023-10-11 16:52 ` [RFC/PATCH v0 10/12] gunyah: CPU execution loop Srivatsa Vaddagiri
2023-10-12 4:43 ` Philippe Mathieu-Daudé
2023-10-12 12:25 ` Srivatsa Vaddagiri
2023-10-11 16:52 ` [RFC/PATCH v0 11/12] gunyah: Workarounds (NOT FOR MERGE) Srivatsa Vaddagiri
2023-10-11 16:52 ` [RFC/PATCH v0 12/12] gunyah: Documentation Srivatsa Vaddagiri
2023-10-12 4:52 ` Philippe Mathieu-Daudé
2023-10-12 12:33 ` Srivatsa Vaddagiri
2023-10-12 14:55 ` Alex Bennée
2023-10-17 9:21 ` Srivatsa Vaddagiri
2023-10-18 15:54 ` Alex Bennée
2023-10-18 16:40 ` [RFC/PATCH v0 00/12] Gunyah hypervisor support Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1g8m5pd.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_cvanscha@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_mnalajal@quicinc.com \
--cc=quic_pheragu@quicinc.com \
--cc=quic_svaddagi@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_yvasi@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).