From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E37EEE7B61C for ; Wed, 4 Oct 2023 13:46:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qo2CD-00023C-Bl; Wed, 04 Oct 2023 09:45:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qo2CB-00022z-BY; Wed, 04 Oct 2023 09:45:48 -0400 Received: from smtp-out2.suse.de ([2001:67c:2178:6::1d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qo2Bt-00088Z-7c; Wed, 04 Oct 2023 09:45:31 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 457BE1F38A; Wed, 4 Oct 2023 13:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696427124; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=80a2pE06qDWpGP3QLbHnXJGKegSAFM0rBb1NVht4a+U=; b=dAmKZG/rqbPoixfVUw02WhMXoAG8Wk3VkpRWedNvKitRomy1S68Q8XbrLAm5oc0nt9PkUH iyrNNhAZyjub5SHY2guTXsSyS5b77mH9FP3GmO+TomvkxyZUmw7czPKNE0MKrkWmTAwbW9 /Gb52YSahKxH9IGtzHvJ0ijOCHCDk/E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696427124; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=80a2pE06qDWpGP3QLbHnXJGKegSAFM0rBb1NVht4a+U=; b=+biMCdORviAfMWaj/FkBOr+1/JEqluXDsip4HKhtRb8hLTV5WAkcL6ztfvLDZYnXGVQW0n xJFLfx05Kc59CbAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CAB69139F9; Wed, 4 Oct 2023 13:45:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hq18JXNsHWXmYAAAMHmgww (envelope-from ); Wed, 04 Oct 2023 13:45:23 +0000 From: Fabiano Rosas To: Juan Quintela , qemu-devel@nongnu.org Cc: Leonardo Bras , Peter Xu , Juan Quintela , Thomas Huth , Li Zhijian , qemu-s390x@nongnu.org, Steve Sistare , Michael Galaxy , =?utf-8?Q?Daniel_P_=2E_Berrang=C3=A9?= Subject: Re: [PULL 09/11] migration: file URI In-Reply-To: <20231004124038.16002-10-quintela@redhat.com> References: <20231004124038.16002-1-quintela@redhat.com> <20231004124038.16002-10-quintela@redhat.com> Date: Wed, 04 Oct 2023 10:45:21 -0300 Message-ID: <87y1gi4i32.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2001:67c:2178:6::1d; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Juan Quintela writes: > From: Steve Sistare > > Extend the migration URI to support file:. This can be used for > any migration scenario that does not require a reverse path. It can be > used as an alternative to 'exec:cat > file' in minimized containers that > do not contain /bin/sh, and it is easier to use than the fd: URI. > It can be used in HMP commands, and as a qemu command-line parameter. > > For best performance, guest ram should be shared and x-ignore-shared > should be true, so guest pages are not written to the file, in which case > the guest may remain running. If ram is not so configured, then the user > is advised to stop the guest first. Otherwise, a busy guest may re-dirty > the same page, causing it to be appended to the file multiple times, > and the file may grow unboundedly. That issue is being addressed in the > "fixed-ram" patch series. > > Signed-off-by: Steve Sistare > Tested-by: Michael Galaxy > Reviewed-by: Michael Galaxy > Reviewed-by: Fabiano Rosas > Reviewed-by: Peter Xu > Reviewed-by: Daniel P. Berrang=C3=A9 > Reviewed-by: Juan Quintela > Signed-off-by: Juan Quintela > Message-ID: <1694182931-61390-2-git-send-email-steven.sistare@oracle.com> Juan, FYI we have tests for this feature already reviewed and ready to merge: [PATCH v5 0/6] migration: Test the new "file:" migration https://lore.kernel.org/r/20230712190742.22294-1-farosas@suse.de