From: Markus Armbruster <armbru@redhat.com>
To: Victor Toso <victortoso@redhat.com>
Cc: qemu-devel@nongnu.org, "John Snow" <jsnow@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v3 00/10] Validate and test qapi examples
Date: Thu, 21 Sep 2023 13:21:00 +0200 [thread overview]
Message-ID: <87y1gz6acj.fsf@pond.sub.org> (raw)
In-Reply-To: <20230919201857.675913-1-victortoso@redhat.com> (Victor Toso's message of "Tue, 19 Sep 2023 22:18:47 +0200")
Victor Toso <victortoso@redhat.com> writes:
> Hi,
>
> v2: https://lists.gnu.org/archive/html/qemu-devel/2023-09/msg02383.html
>
> - Sorry Markus, I kept the two last 'fix example' patches as I don't
> fully remember how we should go with it.
That's fine.
I see two sane alternatives:
1. Add suitable elision syntax. Happy to discuss details, but I think
we should discuss my review of PATCH 10 before we complicate matters
further.
2. Decide we don't need elisions. Delete the ones we have. I'd like to
see an argument that the ones we have are not helpful enough to justfify
the effort to keep them.
> Not taking them but taking
> the generator would be bad as we would fail the build.
Understood.
[...]
prev parent reply other threads:[~2023-09-21 13:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 20:18 [PATCH v3 00/10] Validate and test qapi examples Victor Toso
2023-09-19 20:18 ` [PATCH v3 01/10] qapi: fix example of get-win32-socket command Victor Toso
2023-09-19 20:18 ` [PATCH v3 02/10] qapi: fix example of dumpdtb command Victor Toso
2023-09-19 20:18 ` [PATCH v3 03/10] qapi: fix example of cancel-vcpu-dirty-limit command Victor Toso
2023-09-19 20:18 ` [PATCH v3 04/10] qapi: fix example of set-vcpu-dirty-limit command Victor Toso
2023-09-19 20:18 ` [PATCH v3 05/10] qapi: fix example of calc-dirty-rate command Victor Toso
2023-09-19 20:18 ` [PATCH v3 06/10] qapi: fix example of NETDEV_STREAM_CONNECTED event Victor Toso
2023-09-19 20:18 ` [PATCH v3 07/10] qapi: fix example of query-blockstats command Victor Toso
2023-09-19 20:18 ` [PATCH v3 08/10] qapi: fix example of query-rocker-of-dpa-flows command Victor Toso
2023-09-19 20:18 ` [PATCH v3 09/10] qapi: fix example of query-spice command Victor Toso
2023-09-19 20:18 ` [PATCH v3 10/10] qapi: scripts: add a generator for qapi's examples Victor Toso
2023-09-21 11:06 ` Markus Armbruster
2023-10-18 19:35 ` Victor Toso
2023-10-19 6:26 ` Markus Armbruster
2023-09-21 11:21 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1gz6acj.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=victortoso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).