From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16872C77B73 for ; Wed, 24 May 2023 15:03:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1q1q-0007EI-59; Wed, 24 May 2023 11:03:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1q1l-0006ma-W6 for qemu-devel@nongnu.org; Wed, 24 May 2023 11:03:50 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1q1j-0007sU-HE for qemu-devel@nongnu.org; Wed, 24 May 2023 11:03:49 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f427118644so11963525e9.0 for ; Wed, 24 May 2023 08:03:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684940626; x=1687532626; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=3mCJkaKVUyfsWnJ+UKM1NbNndW4jAHBbawP6IeKsjBU=; b=i0mv37k0Cp5Zhs5JJZ3mlrCrgSUCqpv7hwAfQd3kHbxUapveEs4bnSZTUIWZbxWsmb gGy3mwx68beqQ2NY+U5lpLHp1IGjG1nwgCOAa5sEoLmdkU24zzr7ODdgEgg8648VEM7+ s5uwR1Oi5RtXYTX0C3N4kUsusPnFA+MY/sixvYOF89VVRGdzvh/Hsz8N7nWy85Nsez2e sxqkVGmVeRugATov4m/VyC+BvdmJEIXDvzIF72TxsJyWKHlBpZJSvR+KGiyQVayKjnkE CrMLF15hhDR1CebwI7jogVOQGYEUcVXj7so8y7ElU792xgZRvpZ3oFuacvm9jEpucDLN ylLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684940626; x=1687532626; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3mCJkaKVUyfsWnJ+UKM1NbNndW4jAHBbawP6IeKsjBU=; b=dQ3uh+6Y/LZ9TaL3tHCw+eUjVBsnYSERJM/H6iUy95WjS092jI6GITCjRvWP1W6T+R 9ulwSIBrMwNeR+z/eB+haByegwPdOc12k8lrInNSl4bulD+bPu1FJ8Tn2X8W9UIQ1ifm uvYfrOId/kq3BXff7QRVySd/rLjkeIgIJCgdmk4ZtuFjh3pRwndeZDhwmSZV0jUQzwlq RS+b7HM1BmgV6WnmdpkkhsW7uGohJ9zXt0NMMETLI6r4Z8wrm4aqQ9d6i46lMqz6wuFL lIAghYoyoi8Cf3caixgoTslZp+fMyGUpOSYieBxsw6PeolqbLbIQfjBxtIKiClZzGYoN GIRA== X-Gm-Message-State: AC+VfDz0VoAcLkL9ch197Kym8jGrOGv4s4b15UPZKEARI+OsimIKWc7m 4uGpSCiLPZaR8i9lqjTLQ//sHQ== X-Google-Smtp-Source: ACHHUZ4055B3g1WasRi8I8a7hT177kqWtAcerv1SVggRCUycjWquPyHqVIlR2GAOfiRGkSIiqXcgfA== X-Received: by 2002:a1c:7307:0:b0:3f6:3ad:16a with SMTP id d7-20020a1c7307000000b003f603ad016amr39553wmb.31.1684940625849; Wed, 24 May 2023 08:03:45 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id n11-20020a7bcbcb000000b003f5ffba9ae1sm2622210wmi.24.2023.05.24.08.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 08:03:45 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 312861FFBB; Wed, 24 May 2023 16:03:45 +0100 (BST) References: <20230524093744.88442-1-philmd@linaro.org> <20230524093744.88442-7-philmd@linaro.org> User-agent: mu4e 1.11.6; emacs 29.0.91 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Fam Zheng , Thomas Huth , Paolo Bonzini , Eric Farman , Peter Xu , Hanna Reitz , Christian Borntraeger , "Michael S. Tsirkin" , Raphael Norwitz , Ilya Leoshkevich , Richard Henderson , Eric Auger , "Gonglei (Arei)" , David Hildenbrand , Stefan Hajnoczi , qemu-s390x@nongnu.org, Cornelia Huck , Halil Pasic , qemu-block@nongnu.org, Kevin Wolf , qemu-devel@nongnu.org Subject: Re: [PATCH v2 06/10] hw/virtio/virtio-mem: Use qemu_ram_get_fd() helper Date: Wed, 24 May 2023 16:03:40 +0100 In-reply-to: <20230524093744.88442-7-philmd@linaro.org> Message-ID: <87y1ldvkj2.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Philippe Mathieu-Daud=C3=A9 writes: > Avoid accessing RAMBlock internals, use the provided > qemu_ram_get_fd() getter to get the file descriptor. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: David Hildenbrand > Reviewed-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro