From: "Alex Bennée" <alex.bennee@linaro.org>
To: Claudio Fontana <cfontana@suse.de>
Cc: "Alessandro Di Federico" <ale@rev.ng>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Fabiano Rosas" <fabiano.rosas@suse.com>
Subject: Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu
Date: Mon, 20 Mar 2023 14:33:52 +0000 [thread overview]
Message-ID: <87y1nr7apw.fsf@linaro.org> (raw)
In-Reply-To: <34fc1e42-a0f7-c0fe-300f-3ad78deb8e6c@suse.de>
Claudio Fontana <cfontana@suse.de> writes:
> On 3/20/23 14:32, Alex Bennée wrote:
>>
>> Claudio Fontana <cfontana@suse.de> writes:
>>
>>> How is this conditional on CONFIG_TCG? To me it looks like this breaks !CONFIG_TCG.
>>> Careful, the meson.build in accel/tcg/meson.build is always recursed.
>>
>> Surely it shouldn't be in accel/tcg then?
>
>
> Hi Alex,
>
> maybe we did not understand each other.
>
> What I mean is that accel/tcg/meson.build is not conditionally read, it is _always_ read.
>
> Therefore TCG-specific code needs to be conditionally included using
> the CONFIG_TCG.
Ahh I see now, right I can fix that up next revision if there is
interest in this approach.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-03-20 14:35 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 10:10 [PATCH 00/10] accel/tcg: refactor the cpu-exec loop Alex Bennée
2023-03-20 10:10 ` [PATCH 01/10] metadata: add .git-blame-ignore-revs Alex Bennée
2023-03-21 14:17 ` Philippe Mathieu-Daudé
2023-03-20 10:10 ` [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu Alex Bennée
2023-03-20 12:56 ` Claudio Fontana
2023-03-20 13:32 ` Alex Bennée
2023-03-20 14:01 ` Claudio Fontana
2023-03-20 14:33 ` Alex Bennée [this message]
2023-03-20 16:14 ` Richard Henderson
2023-03-21 16:07 ` Alessandro Di Federico via
2023-03-20 10:10 ` [PATCH 03/10] accel/tcg: move i386 halt handling to sysemu_ops Alex Bennée
2023-03-20 14:52 ` Philippe Mathieu-Daudé
2023-03-20 17:18 ` Alex Bennée
2023-03-20 15:23 ` Claudio Fontana
2023-03-20 15:34 ` Philippe Mathieu-Daudé
2023-03-21 8:47 ` Claudio Fontana
2023-03-20 17:20 ` Alex Bennée
2023-03-20 10:10 ` [PATCH 04/10] accel/tcg: don't bother with ifdef for CPU_DUMP_CCOP Alex Bennée
2023-03-20 16:16 ` Richard Henderson
2023-03-20 16:17 ` Richard Henderson
2023-03-20 10:10 ` [PATCH 05/10] accel/tcg: remove the fake_user_interrupt guards Alex Bennée
2023-03-20 16:18 ` Richard Henderson
2023-03-20 10:10 ` [PATCH 06/10] includes: move irq definitions out of cpu-all.h Alex Bennée
2023-03-20 16:20 ` Richard Henderson
2023-03-21 16:06 ` Alessandro Di Federico via
2023-03-22 5:25 ` Richard Henderson
2023-03-22 21:15 ` Alessandro Di Federico
2023-03-20 10:10 ` [PATCH 07/10] accel/tcg: use QEMU_IOTHREAD_LOCK_GUARD to cover the exit Alex Bennée
2023-03-20 14:55 ` Philippe Mathieu-Daudé
2023-03-20 16:21 ` Richard Henderson
2023-03-20 10:10 ` [PATCH 08/10] accel/tcg: push i386 specific hacks into handle_cpu_interrupt callback Alex Bennée
2023-03-20 16:27 ` Richard Henderson
2023-03-20 17:14 ` Alex Bennée
2023-03-21 6:04 ` Richard Henderson
2023-03-20 10:10 ` [PATCH 09/10] accel/tcg: re-inline the filtering of virtual IRQs but data driven Alex Bennée
2023-03-20 14:58 ` Philippe Mathieu-Daudé
2023-03-20 16:30 ` Richard Henderson
2023-03-20 10:10 ` [PATCH 10/10] accel/tcg: remove unused includes Alex Bennée
2023-03-20 16:30 ` Richard Henderson
2023-03-21 16:07 ` Alessandro Di Federico via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1nr7apw.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=ale@rev.ng \
--cc=cfontana@suse.de \
--cc=eduardo@habkost.net \
--cc=fabiano.rosas@suse.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).