qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Willem van de Velde <williamvdvelde@gmail.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] Add qemu qcode support for keys F13 to F24
Date: Mon, 06 Mar 2023 12:30:37 +0000	[thread overview]
Message-ID: <87y1oaqcua.fsf@linaro.org> (raw)
In-Reply-To: <20230301125211.278808-1-williamvdvelde@gmail.com>


Willem van de Velde <williamvdvelde@gmail.com> writes:

> To be able to use the function keys F13 to F24 these should be defined in de keycodemapdb and added to the qapi.
> The keycodemapdb is updated in its own repository, this patch enables the use of those keys within qemu.
>
> Signed-off-by: Willem van de Velde <williamvdvelde@gmail.com>

Adding maintainer to CC list so this doesn't get lost.

For reference from:
https://qemu.readthedocs.io/en/latest/devel/submitting-a-patch.html#cc-the-relevant-maintainer

  git config sendemail.cccmd 'scripts/get_maintainer.pl --nogit-fallback'

will configure git send-email to do this automatically.

> ---
>  qapi/ui.json    | 15 ++++++++++++++-
>  ui/keycodemapdb |  2 +-
>  2 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/ui.json b/qapi/ui.json
> index 0abba3e930..98322342f7 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -886,6 +886,19 @@
>  # @lang1: since 6.1
>  # @lang2: since 6.1
>  #
> +# @f13: since 8.0
> +# @f14: since 8.0
> +# @f15: since 8.0
> +# @f16: since 8.0
> +# @f17: since 8.0
> +# @f18: since 8.0
> +# @f19: since 8.0
> +# @f20: since 8.0
> +# @f21: since 8.0
> +# @f22: since 8.0
> +# @f23: since 8.0
> +# @f24: since 8.0
> +#
>  # 'sysrq' was mistakenly added to hack around the fact that
>  # the ps2 driver was not generating correct scancodes sequences
>  # when 'alt+print' was pressed. This flaw is now fixed and the
> @@ -918,7 +931,7 @@
>              'volumeup', 'volumedown', 'mediaselect',
>              'mail', 'calculator', 'computer',
>              'ac_home', 'ac_back', 'ac_forward', 'ac_refresh', 'ac_bookmarks',
> -            'lang1', 'lang2' ] }
> +            'lang1', 'lang2','f13','f14','f15','f16','f17','f18','f19','f20','f21','f22','f23','f24' ] }
>  
>  ##
>  # @KeyValueKind:
> diff --git a/ui/keycodemapdb b/ui/keycodemapdb
> index d21009b1c9..f5772a62ec 160000
> --- a/ui/keycodemapdb
> +++ b/ui/keycodemapdb
> @@ -1 +1 @@
> -Subproject commit d21009b1c9f94b740ea66be8e48a1d8ad8124023
> +Subproject commit f5772a62ec52591ff6870b7e8ef32482371f22c6


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  parent reply	other threads:[~2023-03-06 12:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01 12:52 [PATCH] Add qemu qcode support for keys F13 to F24 Willem van de Velde
2023-03-02 19:35 ` Daniel P. Berrangé
2023-03-06 12:30 ` Alex Bennée [this message]
2023-03-07 10:16   ` Daniel P. Berrangé
  -- strict thread matches above, loose matches on Subject: below --
2023-03-01  9:21 Willem van de Velde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1oaqcua.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=williamvdvelde@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).