From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A7F8C4332F for ; Sun, 11 Dec 2022 16:49:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4PVb-0003ya-4G; Sun, 11 Dec 2022 11:48:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4PVY-0003yQ-IL for qemu-devel@nongnu.org; Sun, 11 Dec 2022 11:48:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4PVX-0003Db-8J for qemu-devel@nongnu.org; Sun, 11 Dec 2022 11:48:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670777333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y8ju7w2UmcJO9SmwuJGvUKAllv5HDsFm6lQDJ3Gc8WE=; b=gpb3Mkko4Aw+wnk5o+Qk9UIcU5FrxsvBgeB4g4KPAkZVm+fyqcB0CnDToRUpYvHH2Kxy6n Optw92GtEQ0vA3G1B7p+wwgEEKdNnUKutnJikXX0GaImhfcNoE7TQFdNMwmyM/OXX8j/eQ JzW1u0ZwkpX5Xqxw75MrymLUsCt01Qw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-661-dl_SuXycMtSPUMjLkfRAvg-1; Sun, 11 Dec 2022 11:48:52 -0500 X-MC-Unique: dl_SuXycMtSPUMjLkfRAvg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 02CF3803533 for ; Sun, 11 Dec 2022 16:48:52 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.195.144]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C94D04EA4D; Sun, 11 Dec 2022 16:48:51 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9937B21E6900; Sun, 11 Dec 2022 17:48:48 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Cc: kraxel@redhat.com, dgilbert@redhat.com Subject: Re: [PATCH 5/9] ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c References: <20221201061311.3619052-1-armbru@redhat.com> <20221201061311.3619052-6-armbru@redhat.com> <87wn7b1ve8.fsf@pond.sub.org> Date: Sun, 11 Dec 2022 17:48:48 +0100 In-Reply-To: <87wn7b1ve8.fsf@pond.sub.org> (Markus Armbruster's message of "Thu, 01 Dec 2022 07:38:07 +0100") Message-ID: <87y1rd998v.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Markus Armbruster writes: > Markus Armbruster writes: > >> This moves these commands from MAINTAINERS section "Human >> Monitor (HMP)" to "Graphics". Make that 'section "QMP"', of course. >> Command add-client applies to socket character devices in addition to >> display devices. Move it anyway. Aside: the way @protocol character >> device IDs and display types is bad design. > > Last sentence no verb. Trying again: > > Aside: @protocol is either a display type or else a character device > ID. Bad design. > >> Signed-off-by: Markus Armbruster