From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8638FC433EF for ; Mon, 14 Mar 2022 22:56:42 +0000 (UTC) Received: from localhost ([::1]:49854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTtcH-00065o-Bt for qemu-devel@archiver.kernel.org; Mon, 14 Mar 2022 18:56:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTtaz-0004lV-6J for qemu-devel@nongnu.org; Mon, 14 Mar 2022 18:55:21 -0400 Received: from [2a00:1450:4864:20::62e] (port=34496 helo=mail-ej1-x62e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTtaq-0004TZ-Vt for qemu-devel@nongnu.org; Mon, 14 Mar 2022 18:55:15 -0400 Received: by mail-ej1-x62e.google.com with SMTP id gb39so37023210ejc.1 for ; Mon, 14 Mar 2022 15:55:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=y2Q/inabtnNQGMD1STwoVXN1cYBrHr5EEIPdNdUQA8M=; b=B3Ph160SYsccuR00NVF/PocSGd5KiKeGpNJQ+RhhnFCFJnM/0IodWWwadeJcwcmY+1 p7mK/8zR77h4sFn6DIJS4jdi8ycIdBa6GBZQ6BXKTb3vVVmexiMZjgQShP38GekQRhLR OFFa1yqM6ceyWSEt+cqGDYutIRVgD92f7oipq5Mg9BeeGJDwvUB0CNZczv+2oAKHL7RU XtPyTH4G288CVUiVrITqt6JutYE0Qb0TgEX3xgugz+3QvZ9/Wgx/vbThbekaqzBLCdmr djWEZim/YuTV6z1bWLbTLYuLWSD1hi3Ql3isNXnEieORmw90FONvnt5WSh0jULarEWnD mY5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=y2Q/inabtnNQGMD1STwoVXN1cYBrHr5EEIPdNdUQA8M=; b=i2o4ICJ6LnShykZPJiNMbMqAkgipCDJsLoT+QoAN3kTPy4Kw38it2HSydjH6T5eKfj 1Y4slBrjBpc6s5iZNk6ZRoK8wNxmZdVM2SvPsE4Jy/TlMNeWiBCT/x7LvzSH/F+I1boO GsyaJSivo6s1vOaVirQRN5dSFCUYZ29rbUPPjRnKkqdHhPIqdQW4rdFGcZTyTpxEUJw8 nSoniNZN+o90IQILKEp8ksNnccfKX8qqUaqcCBZ2x9R2SJuXodL351/Hb0tJcER0Qv2p TnozObhpndhE+ugHe1x5gSK0/wRHwXKBUnkp5E6F6dveMxO1uSqgS59BY/Q9rVBSYLDT r9UQ== X-Gm-Message-State: AOAM530vuVnrrE1WiowI5Vzu3n3Qd7Pw3OIvb+Vlx0coOOkBnVCnj34z glxNKv8QK/8whxHTA5NeJZCEzA== X-Google-Smtp-Source: ABdhPJwH8+Emwxdug9WRaA5Pn7fnzwuIyGSHomy+CWFwvXssMscVFR/0TRAwIvo8vB6/HLdlnvsYkw== X-Received: by 2002:a17:907:3f9c:b0:6d8:116d:476b with SMTP id hr28-20020a1709073f9c00b006d8116d476bmr20220654ejc.432.1647298511045; Mon, 14 Mar 2022 15:55:11 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id f7-20020a17090631c700b006b293ddbca1sm7314593ejf.35.2022.03.14.15.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 15:55:10 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 47A0E1FFB7; Mon, 14 Mar 2022 22:55:09 +0000 (GMT) References: <20220314160108.1440470-1-armbru@redhat.com> <20220314160108.1440470-4-armbru@redhat.com> User-agent: mu4e 1.7.10; emacs 28.0.92 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Markus Armbruster Subject: Re: [PATCH 3/3] Use g_new() & friends where that makes obvious sense Date: Mon, 14 Mar 2022 22:52:52 +0000 In-reply-to: <20220314160108.1440470-4-armbru@redhat.com> Message-ID: <87y21c401e.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::62e (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62e.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Daniel Henrique Barboza , kvm@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Christian Schoenebeck , qemu-devel@nongnu.org, Peter Xu , Klaus Jensen , KONRAD Frederic , Konstantin Kostiuk , Gerd Hoffmann , Ani Sinha , Reinoud Zandijk , Eric Blake , Sunil Muthuswamy , Stefano Stabellini , xen-devel@lists.xenproject.org, Yoshinori Sato , Juan Quintela , Paul Durrant , Magnus Damm , Kamil Rytarowski , "Gonglei \(Arei\)" , =?utf-8?Q?Herv=C3=A9?= Poussineau , Michael Roth , Anthony Perard , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Artyom Tarasenko , Laurent Vivier , Aleksandar Rikalo , Amit Shah , Mark Cave-Ayland , haxm-team@intel.com, Richard Henderson , Greg Kurz , Fabien Chouteau , Yuval Shaia , Thomas Huth , Eric Auger , Alex Williamson , qemu-arm@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Pavel Dovgalyuk , Paolo Bonzini , Keith Busch , qemu-ppc@nongnu.org, David Hildenbrand , John Snow , David Gibson , Eduardo Habkost , Vladimir Sementsov-Ogievskiy , =?utf-8?Q?Daniel_P=2E_Berrang=C3=A9?= , qemu-block@nongnu.org, Max Filippov , qemu-s390x@nongnu.org, Patrick Venture , Cornelia Huck , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Jean-Christophe Dubois , Corey Minyard , Wenchao Wang , Igor Mammedov , "Dr. David Alan Gilbert" , Colin Xu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Markus Armbruster writes: > g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, > for two reasons. One, it catches multiplication overflowing size_t. > Two, it returns T * rather than void *, which lets the compiler catch > more type errors. > > diff --git a/semihosting/config.c b/semihosting/config.c > index 137171b717..6d48ec9566 100644 > --- a/semihosting/config.c > +++ b/semihosting/config.c > @@ -98,7 +98,7 @@ static int add_semihosting_arg(void *opaque, > if (strcmp(name, "arg") =3D=3D 0) { > s->argc++; > /* one extra element as g_strjoinv() expects NULL-terminated arr= ay */ > - s->argv =3D g_realloc(s->argv, (s->argc + 1) * sizeof(void *)); > + s->argv =3D g_renew(void *, s->argv, s->argc + 1); This did indeed break CI because s->argv is an array of *char: ../semihosting/config.c:101:17: error: assignment to =E2=80=98const char **= =E2=80=99 from incompatible pointer type =E2=80=98void **=E2=80=99 [-Werror= =3Dincompatible-pointer-types] 101 | s->argv =3D g_renew(void *, s->argv, s->argc + 1); | ^ cc1: all warnings being treated as errors So it did the job of type checking but failed to build ;-) --=20 Alex Benn=C3=A9e