* [PATCH] gitlab-ci: Enable docs in the centos job
@ 2022-01-04 9:12 Thomas Huth
2022-01-04 9:22 ` Marc-André Lureau
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thomas Huth @ 2022-01-04 9:12 UTC (permalink / raw)
To: qemu-devel
Cc: Marc-André Lureau, Alex Bennée, Beraldo Leal,
Wainer dos Santos Moschetta, Philippe Mathieu-Daudé
We just ran into a problem that the docs don't build on RHEL8 / CentOS 8
anymore. Seems like these distros are using one of the oldest Sphinx
versions that we still have to support. Thus enable the docs build in
the CI on CentOS so that such bugs don't slip in so easily again.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Based-on: <20220104074649.1712440-1-marcandre.lureau@redhat.com>
.gitlab-ci.d/buildtest.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index d52fde23ec..083d1b25e5 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -164,7 +164,7 @@ build-system-centos:
variables:
IMAGE: centos8
CONFIGURE_ARGS: --disable-nettle --enable-gcrypt --enable-fdt=system
- --enable-modules --enable-trace-backends=dtrace
+ --enable-modules --enable-trace-backends=dtrace --enable-docs
TARGETS: ppc64-softmmu or1k-softmmu s390x-softmmu
x86_64-softmmu rx-softmmu sh4-softmmu nios2-softmmu
MAKE_CHECK_ARGS: check-build
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] gitlab-ci: Enable docs in the centos job
2022-01-04 9:12 [PATCH] gitlab-ci: Enable docs in the centos job Thomas Huth
@ 2022-01-04 9:22 ` Marc-André Lureau
2022-01-04 11:19 ` Philippe Mathieu-Daudé
2022-01-05 9:44 ` Alex Bennée
2 siblings, 0 replies; 5+ messages in thread
From: Marc-André Lureau @ 2022-01-04 9:22 UTC (permalink / raw)
To: Thomas Huth
Cc: Philippe Mathieu-Daudé, Alex Bennée, qemu-devel,
Wainer dos Santos Moschetta, Beraldo Leal
On Tue, Jan 4, 2022 at 1:12 PM Thomas Huth <thuth@redhat.com> wrote:
>
> We just ran into a problem that the docs don't build on RHEL8 / CentOS 8
> anymore. Seems like these distros are using one of the oldest Sphinx
> versions that we still have to support. Thus enable the docs build in
> the CI on CentOS so that such bugs don't slip in so easily again.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> Based-on: <20220104074649.1712440-1-marcandre.lureau@redhat.com>
>
> .gitlab-ci.d/buildtest.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
> index d52fde23ec..083d1b25e5 100644
> --- a/.gitlab-ci.d/buildtest.yml
> +++ b/.gitlab-ci.d/buildtest.yml
> @@ -164,7 +164,7 @@ build-system-centos:
> variables:
> IMAGE: centos8
> CONFIGURE_ARGS: --disable-nettle --enable-gcrypt --enable-fdt=system
> - --enable-modules --enable-trace-backends=dtrace
> + --enable-modules --enable-trace-backends=dtrace --enable-docs
> TARGETS: ppc64-softmmu or1k-softmmu s390x-softmmu
> x86_64-softmmu rx-softmmu sh4-softmmu nios2-softmmu
> MAKE_CHECK_ARGS: check-build
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gitlab-ci: Enable docs in the centos job
2022-01-04 9:12 [PATCH] gitlab-ci: Enable docs in the centos job Thomas Huth
2022-01-04 9:22 ` Marc-André Lureau
@ 2022-01-04 11:19 ` Philippe Mathieu-Daudé
2022-01-05 9:44 ` Alex Bennée
2 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-01-04 11:19 UTC (permalink / raw)
To: Thomas Huth
Cc: Marc-André Lureau, Alex Bennée,
qemu-devel@nongnu.org Developers, Wainer dos Santos Moschetta,
Beraldo Leal
On Tue, Jan 4, 2022 at 10:12 AM Thomas Huth <thuth@redhat.com> wrote:
>
> We just ran into a problem that the docs don't build on RHEL8 / CentOS 8
> anymore. Seems like these distros are using one of the oldest Sphinx
> versions that we still have to support. Thus enable the docs build in
> the CI on CentOS so that such bugs don't slip in so easily again.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Based-on: <20220104074649.1712440-1-marcandre.lureau@redhat.com>
>
> .gitlab-ci.d/buildtest.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gitlab-ci: Enable docs in the centos job
2022-01-04 9:12 [PATCH] gitlab-ci: Enable docs in the centos job Thomas Huth
2022-01-04 9:22 ` Marc-André Lureau
2022-01-04 11:19 ` Philippe Mathieu-Daudé
@ 2022-01-05 9:44 ` Alex Bennée
2022-01-05 10:14 ` Thomas Huth
2 siblings, 1 reply; 5+ messages in thread
From: Alex Bennée @ 2022-01-05 9:44 UTC (permalink / raw)
To: Thomas Huth
Cc: Marc-André Lureau, Philippe Mathieu-Daudé, qemu-devel,
Wainer dos Santos Moschetta, Beraldo Leal
Thomas Huth <thuth@redhat.com> writes:
> We just ran into a problem that the docs don't build on RHEL8 / CentOS 8
> anymore. Seems like these distros are using one of the oldest Sphinx
> versions that we still have to support. Thus enable the docs build in
> the CI on CentOS so that such bugs don't slip in so easily again.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Queued to testing/next, thanks.
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gitlab-ci: Enable docs in the centos job
2022-01-05 9:44 ` Alex Bennée
@ 2022-01-05 10:14 ` Thomas Huth
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2022-01-05 10:14 UTC (permalink / raw)
To: Alex Bennée
Cc: Marc-André Lureau, Philippe Mathieu-Daudé, qemu-devel,
Wainer dos Santos Moschetta, Beraldo Leal
On 05/01/2022 10.44, Alex Bennée wrote:
>
> Thomas Huth <thuth@redhat.com> writes:
>
>> We just ran into a problem that the docs don't build on RHEL8 / CentOS 8
>> anymore. Seems like these distros are using one of the oldest Sphinx
>> versions that we still have to support. Thus enable the docs build in
>> the CI on CentOS so that such bugs don't slip in so easily again.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Queued to testing/next, thanks.
Note that you need Marc-André's fix first, too. But I'm also planning a pull
request with a bunch of misc other patches soon, so I can also stick these
two patches in there, too.
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-05 10:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-04 9:12 [PATCH] gitlab-ci: Enable docs in the centos job Thomas Huth
2022-01-04 9:22 ` Marc-André Lureau
2022-01-04 11:19 ` Philippe Mathieu-Daudé
2022-01-05 9:44 ` Alex Bennée
2022-01-05 10:14 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).