From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: figlesia@xilinx.com, peter.maydell@linaro.org,
edgar.iglesias@xilinx.com, sai.pavan.boddu@xilinx.com,
frasse.iglesias@gmail.com, alistair@alistair23.me,
richard.henderson@linaro.org, frederic.konrad@adacore.com,
qemu-arm@nongnu.org, sstabellini@kernel.org, philmd@redhat.com,
luc.michel@greensocs.com
Subject: Re: [PATCH v1 1/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot
Date: Thu, 31 Oct 2019 15:01:02 +0000 [thread overview]
Message-ID: <87y2x16jtd.fsf@linaro.org> (raw)
In-Reply-To: <20191031040830.18800-2-edgar.iglesias@xilinx.com>
Edgar E. Iglesias <edgar.iglesias@xilinx.com> writes:
> Rebuild hflags when modifying CPUState at boot.
>
> Fixes: e979972a6a
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
> hw/arm/boot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/boot.c b/hw/arm/boot.c
> index c264864c11..ef6724960c 100644
> --- a/hw/arm/boot.c
> +++ b/hw/arm/boot.c
> @@ -786,6 +786,7 @@ static void do_cpu_reset(void *opaque)
> info->secondary_cpu_reset_hook(cpu, info);
> }
> }
> + arm_rebuild_hflags(env);
Do we just get away with armv7m_reset because there is no futzing about
with execution state?
Anyway:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> }
> }
--
Alex Bennée
next prev parent reply other threads:[~2019-10-31 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 4:08 [PATCH v1 0/1] hw/arm/boot: Rebuild hflags when modifying CPUState at boot Edgar E. Iglesias
2019-10-31 4:08 ` [PATCH v1 1/1] " Edgar E. Iglesias
2019-10-31 14:10 ` Philippe Mathieu-Daudé
2019-10-31 15:01 ` Alex Bennée [this message]
2019-10-31 18:33 ` Luc Michel
2019-11-01 8:25 ` [PATCH v1 0/1] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2x16jtd.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@xilinx.com \
--cc=figlesia@xilinx.com \
--cc=frasse.iglesias@gmail.com \
--cc=frederic.konrad@adacore.com \
--cc=luc.michel@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sai.pavan.boddu@xilinx.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).