* [Qemu-devel] [PATCH] tests/docker: fix typo for debian9-mxe
@ 2019-09-17 18:55 John Snow
2019-09-17 19:40 ` Philippe Mathieu-Daudé
2019-09-18 11:35 ` Alex Bennée
0 siblings, 2 replies; 4+ messages in thread
From: John Snow @ 2019-09-17 18:55 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Alex Bennée, John Snow,
Philippe Mathieu-Daudé
We spelled it debian-9-mxe, but the image is debian9-mxe.
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/docker/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 50a400b573..7eac1516f6 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -7,7 +7,7 @@ DOCKER_FILES_DIR := $(SRC_PATH)/tests/docker/dockerfiles
DOCKER_DEPRECATED_IMAGES := debian
# we don't run tests on intermediate images (used as base by another image)
DOCKER_PARTIAL_IMAGES := debian debian8 debian9 debian10 debian-sid
-DEBIAN_PARTIAL_IMAGES += debian8-mxe debian-9-mxe debian-ports debian-bootstrap
+DEBIAN_PARTIAL_IMAGES += debian8-mxe debian9-mxe debian-ports debian-bootstrap
DOCKER_IMAGES := $(filter-out $(DOCKER_DEPRECATED_IMAGES),$(sort $(notdir $(basename $(wildcard $(DOCKER_FILES_DIR)/*.docker)))))
DOCKER_TARGETS := $(patsubst %,docker-image-%,$(DOCKER_IMAGES))
# Use a global constant ccache directory to speed up repetitive builds
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/docker: fix typo for debian9-mxe
2019-09-17 18:55 [Qemu-devel] [PATCH] tests/docker: fix typo for debian9-mxe John Snow
@ 2019-09-17 19:40 ` Philippe Mathieu-Daudé
2019-09-18 11:35 ` Alex Bennée
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-09-17 19:40 UTC (permalink / raw)
To: John Snow, qemu-devel; +Cc: Fam Zheng, Alex Bennée
On 9/17/19 8:55 PM, John Snow wrote:
> We spelled it debian-9-mxe, but the image is debian9-mxe.
Oops I missed that, good catch.
Fixes: 44d5a8bf5d2
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/docker/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 50a400b573..7eac1516f6 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -7,7 +7,7 @@ DOCKER_FILES_DIR := $(SRC_PATH)/tests/docker/dockerfiles
> DOCKER_DEPRECATED_IMAGES := debian
> # we don't run tests on intermediate images (used as base by another image)
> DOCKER_PARTIAL_IMAGES := debian debian8 debian9 debian10 debian-sid
> -DEBIAN_PARTIAL_IMAGES += debian8-mxe debian-9-mxe debian-ports debian-bootstrap
> +DEBIAN_PARTIAL_IMAGES += debian8-mxe debian9-mxe debian-ports debian-bootstrap
> DOCKER_IMAGES := $(filter-out $(DOCKER_DEPRECATED_IMAGES),$(sort $(notdir $(basename $(wildcard $(DOCKER_FILES_DIR)/*.docker)))))
> DOCKER_TARGETS := $(patsubst %,docker-image-%,$(DOCKER_IMAGES))
> # Use a global constant ccache directory to speed up repetitive builds
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/docker: fix typo for debian9-mxe
2019-09-17 18:55 [Qemu-devel] [PATCH] tests/docker: fix typo for debian9-mxe John Snow
2019-09-17 19:40 ` Philippe Mathieu-Daudé
@ 2019-09-18 11:35 ` Alex Bennée
2019-09-18 15:37 ` John Snow
1 sibling, 1 reply; 4+ messages in thread
From: Alex Bennée @ 2019-09-18 11:35 UTC (permalink / raw)
To: John Snow; +Cc: Fam Zheng, Philippe Mathieu-Daudé, qemu-devel
John Snow <jsnow@redhat.com> writes:
> We spelled it debian-9-mxe, but the image is debian9-mxe.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
I'll merge this fix with the other typo fix while I'm at it. Thanks.
> ---
> tests/docker/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 50a400b573..7eac1516f6 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -7,7 +7,7 @@ DOCKER_FILES_DIR := $(SRC_PATH)/tests/docker/dockerfiles
> DOCKER_DEPRECATED_IMAGES := debian
> # we don't run tests on intermediate images (used as base by another image)
> DOCKER_PARTIAL_IMAGES := debian debian8 debian9 debian10 debian-sid
> -DEBIAN_PARTIAL_IMAGES += debian8-mxe debian-9-mxe debian-ports debian-bootstrap
> +DEBIAN_PARTIAL_IMAGES += debian8-mxe debian9-mxe debian-ports debian-bootstrap
> DOCKER_IMAGES := $(filter-out $(DOCKER_DEPRECATED_IMAGES),$(sort $(notdir $(basename $(wildcard $(DOCKER_FILES_DIR)/*.docker)))))
> DOCKER_TARGETS := $(patsubst %,docker-image-%,$(DOCKER_IMAGES))
> # Use a global constant ccache directory to speed up repetitive builds
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/docker: fix typo for debian9-mxe
2019-09-18 11:35 ` Alex Bennée
@ 2019-09-18 15:37 ` John Snow
0 siblings, 0 replies; 4+ messages in thread
From: John Snow @ 2019-09-18 15:37 UTC (permalink / raw)
To: Alex Bennée; +Cc: Fam Zheng, Philippe Mathieu-Daudé, qemu-devel
On 9/18/19 7:35 AM, Alex Bennée wrote:
>
> John Snow <jsnow@redhat.com> writes:
>
>> We spelled it debian-9-mxe, but the image is debian9-mxe.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>
> I'll merge this fix with the other typo fix while I'm at it. Thanks.
>
ACK
thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-18 16:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-17 18:55 [Qemu-devel] [PATCH] tests/docker: fix typo for debian9-mxe John Snow
2019-09-17 19:40 ` Philippe Mathieu-Daudé
2019-09-18 11:35 ` Alex Bennée
2019-09-18 15:37 ` John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).