From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cX77z-0005M2-T6 for qemu-devel@nongnu.org; Fri, 27 Jan 2017 09:03:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cX77v-0002jD-Py for qemu-devel@nongnu.org; Fri, 27 Jan 2017 09:03:47 -0500 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:38074) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cX77v-0002j9-JH for qemu-devel@nongnu.org; Fri, 27 Jan 2017 09:03:43 -0500 Received: by mail-wm0-x233.google.com with SMTP id r144so139187369wme.1 for ; Fri, 27 Jan 2017 06:03:43 -0800 (PST) References: <1484746795-19523-1-git-send-email-douly.fnst@cn.fujitsu.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1484746795-19523-1-git-send-email-douly.fnst@cn.fujitsu.com> Date: Fri, 27 Jan 2017 14:03:40 +0000 Message-ID: <87y3xw8urn.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2] vl: Ensure the cpu_synchronize_all_post_init() in the appropriate location List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dou Liyang Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, rth@twiddle.net, sergey.fedorov@linaro.org, izumi.taku@jp.fujitsu.com, caoj.fnst@cn.fujitsu.com, fanc.fnst@cn.fujitsu.com Dou Liyang writes: > At the Qemu initialization, we call the cpu_synchronize_all_post_init() > to synchronize All CPU states to KVM in the ./vl.c::main(). > > Currently, it is called before we initialize the CPUs, which created by > "-device" command, So, these CPUs may be ignored to synchronize. > > The patch moves the numa_post_machine_init func in the appropriate > location to make sure that all the CPUs has already been created > when it is called. This doesn't match what the patch does (the function is cpu_synchronise_all_post_init) but I see another patch is already merged that moved the NUMA one. I'm afraid you'll need to re-base anyway because it no longer applies cleanly. > > Signed-off-by: Dou Liyang > --- > > Change log v1-> v2: > 1. Split it from > https://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg03354.html > 2. Rewrite the log. > > vl.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/vl.c b/vl.c > index c643d3f..38269be 100644 > --- a/vl.c > +++ b/vl.c > @@ -4547,8 +4547,6 @@ int main(int argc, char **argv, char **envp) > > audio_init(); > > - cpu_synchronize_all_post_init(); > - > numa_post_machine_init(); > > if (qemu_opts_foreach(qemu_find_opts("fw_cfg"), > @@ -4571,6 +4569,9 @@ int main(int argc, char **argv, char **envp) > device_init_func, NULL, NULL)) { > exit(1); > } > + > + cpu_synchronize_all_post_init(); > + > rom_reset_order_override(); > > /* Did we create any drives that we failed to create a device for? */ -- Alex Bennée