Re: [Qemu-devel] [PATCH 04/17] migration: introduce postcopy-only pending

[Juan Quintela <quintela@redhat.com>]

Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote:
> There would be savevm states (dirty-bitmap) which can migrate only in
> postcopy stage. The corresponding pending is introduced here.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  include/migration/vmstate.h |  5 +++--
>  include/sysemu/sysemu.h     |  5 +++--
>  migration/block.c           |  7 ++++---
>  migration/migration.c       | 15 ++++++++-------
>  migration/ram.c             |  9 +++++----
>  migration/savevm.c          | 14 ++++++++------
>  migration/trace-events      |  2 +-
>  7 files changed, 32 insertions(+), 25 deletions(-)
>
> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> index 5c30ef7..dc656be 100644
> --- a/include/migration/vmstate.h
> +++ b/include/migration/vmstate.h
> @@ -58,8 +58,9 @@ typedef struct SaveVMHandlers {
>      /* This runs outside the iothread lock!  */
>      int (*save_live_setup)(QEMUFile *f, void *opaque);
>      void (*save_live_pending)(QEMUFile *f, void *opaque, uint64_t max_size,
> -                              uint64_t *non_postcopiable_pending,
> -                              uint64_t *postcopiable_pending);
> +                              uint64_t *res_precopy_only,
> +                              uint64_t *res_compatible,
> +                              uint64_t *res_postcopy_only);

ok, this got just out of control, this paramenters need to move to one
struct, but as the code was already ugly, I will not put the burden on
you O:-)

But you need to document what means each of the new fields, please O:-)

I really think that doing the rename of the fields in one patch, and
then add the res_compat in a differnt one will make  things easier to
review.


Reviewed-by: Juan Quintela <quintela@redhat.com>

If you have to send a new review, just add documentation to the variable
names, otherwise, send an additional patch when this is merged.