From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6IYq-0006Bd-A4 for qemu-devel@nongnu.org; Fri, 27 May 2016 10:16:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6IYj-0007TS-Lt for qemu-devel@nongnu.org; Fri, 27 May 2016 10:16:23 -0400 Received: from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:35396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6IYj-0007TM-Gk for qemu-devel@nongnu.org; Fri, 27 May 2016 10:16:17 -0400 Received: by mail-oi0-x233.google.com with SMTP id w184so168900084oiw.2 for ; Fri, 27 May 2016 07:16:17 -0700 (PDT) References: <1464310815-13554-1-git-send-email-rth@twiddle.net> <1464310815-13554-2-git-send-email-rth@twiddle.net> <57481CAC.4070205@gmail.com> From: Pranith Kumar In-reply-to: <57481CAC.4070205@gmail.com> Date: Fri, 27 May 2016 10:16:15 -0400 Message-ID: <87y46vbn80.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 01/12] Introduce TCGOpcode for fence instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Fedorov Cc: Richard Henderson , qemu-devel@nongnu.org Sergey Fedorov writes: > On 27/05/16 04:00, Richard Henderson wrote: >> diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h >> index 6d0410c..b772d90 100644 >> --- a/tcg/tcg-opc.h >> +++ b/tcg/tcg-opc.h >> @@ -42,6 +42,8 @@ DEF(br, 0, 0, 1, TCG_OPF_BB_END) >> # define IMPL64 TCG_OPF_64BIT >> #endif >> >> +DEF(fence, 0, 0, 0, TCG_OPF_SIDE_EFFECTS) >> + > > I still think this TCG op needs to have a constant argument of a barrier > type. So that we can distinguish between full, read and write memory > barriers. > Yes, I have a version with this fixed. I will post my patches(v3) with this changed. Thanks, -- Pranith