From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwfOL-0007E8-Hd for qemu-devel@nongnu.org; Tue, 09 Jul 2013 17:24:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwfOK-0000Ba-In for qemu-devel@nongnu.org; Tue, 09 Jul 2013 17:24:09 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:51949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwfOK-0000BM-Ea for qemu-devel@nongnu.org; Tue, 09 Jul 2013 17:24:08 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 9 Jul 2013 17:24:07 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 6CC8838C803B for ; Tue, 9 Jul 2013 17:24:05 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r69LO6Uv214998 for ; Tue, 9 Jul 2013 17:24:06 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r69LO5Ks000353 for ; Tue, 9 Jul 2013 17:24:05 -0400 From: Anthony Liguori In-Reply-To: References: <1371645291-3178-1-git-send-email-mjt@msgid.tls.msk.ru> <874nc337gq.fsf@codemonkey.ws> <51DC5DEA.4060901@msgid.tls.msk.ru> <87li5fsbrd.fsf@codemonkey.ws> Date: Tue, 09 Jul 2013 16:24:02 -0500 Message-ID: <87y59f1l71.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Michael Tokarev , qemu-devel@nongnu.org Peter Maydell writes: > On 9 July 2013 21:45, Anthony Liguori wrote: >> Michael Tokarev writes: >>> 09.07.2013 22:37, Anthony Liguori wrote: >>>> ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic: assertion failed (qfw_cfg_get_u16(fw_cfg, FW_CFG_NOGRAPHIC) == 0): (1 == 0) >>>> GTester: last random seed: R02S25031265f05e4d41efcf758c9ef6043b >>> >>> Sure, because the test is bogus. >> >> No, it's a guest ABI. You cannot change the guest ABI. > > Why the heck are we telling the guest that the user > specified -nographic anyhow? It's a dumb guest ABI... I believe OpenBIOS uses this to determine if it should display messages on serial or on the graphic display. It's actually a useful ABI in that regard. Regards, Anthony Liguori >> -display none != -nographic. >> >> nographic gives you -display none plus a stdio serial port (with muxing >> magic). >> >> -display none should not imply stdio serial port. The vc goes to a >> dummy display. That's a major semantic difference. > > None of these semantics have changed AFAICT. > > -- PMM