From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnUBg-00069d-Ly for qemu-devel@nongnu.org; Fri, 14 Jun 2013 09:37:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UnUBd-0004kL-BY for qemu-devel@nongnu.org; Fri, 14 Jun 2013 09:37:08 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:59179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UnUBd-0004hd-6W for qemu-devel@nongnu.org; Fri, 14 Jun 2013 09:37:05 -0400 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 14 Jun 2013 07:37:00 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 514241FF006B for ; Fri, 14 Jun 2013 07:31:43 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5EDaie3331114 for ; Fri, 14 Jun 2013 07:36:45 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5EDagM5024116 for ; Fri, 14 Jun 2013 07:36:43 -0600 From: Anthony Liguori In-Reply-To: <1371208516-7857-3-git-send-email-armbru@redhat.com> References: <1371208516-7857-1-git-send-email-armbru@redhat.com> <1371208516-7857-3-git-send-email-armbru@redhat.com> Date: Fri, 14 Jun 2013 08:36:37 -0500 Message-ID: <87y5acg6fu.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v3 02/16] qemu-option: check_params() is now unused, drop it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com, alex.williamson@redhat.com, afaerber@suse.de, aviksil@linux.vnet.ibm.com Markus Armbruster writes: > Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > include/qemu/option.h | 2 -- > util/qemu-option.c | 30 ------------------------------ > 2 files changed, 32 deletions(-) > > diff --git a/include/qemu/option.h b/include/qemu/option.h > index bdb6d21..a83c700 100644 > --- a/include/qemu/option.h > +++ b/include/qemu/option.h > @@ -55,8 +55,6 @@ int get_next_param_value(char *buf, int buf_size, > const char *tag, const char **pstr); > int get_param_value(char *buf, int buf_size, > const char *tag, const char *str); > -int check_params(char *buf, int buf_size, > - const char * const *params, const char *str); > > > /* > diff --git a/util/qemu-option.c b/util/qemu-option.c > index 8b74bf1..412c425 100644 > --- a/util/qemu-option.c > +++ b/util/qemu-option.c > @@ -123,36 +123,6 @@ int get_param_value(char *buf, int buf_size, > return get_next_param_value(buf, buf_size, tag, &str); > } > > -int check_params(char *buf, int buf_size, > - const char * const *params, const char *str) > -{ > - const char *p; > - int i; > - > - p = str; > - while (*p != '\0') { > - p = get_opt_name(buf, buf_size, p, '='); > - if (*p != '=') { > - return -1; > - } > - p++; > - for (i = 0; params[i] != NULL; i++) { > - if (!strcmp(params[i], buf)) { > - break; > - } > - } > - if (params[i] == NULL) { > - return -1; > - } > - p = get_opt_value(NULL, 0, p); > - if (*p != ',') { > - break; > - } > - p++; > - } > - return 0; > -} > - > /* > * Searches an option list for an option with the given name > */ > -- > 1.7.11.7