From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTAnP-0008Hp-EI for qemu-devel@nongnu.org; Tue, 30 Oct 2012 08:19:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTAnF-0004mt-Tx for qemu-devel@nongnu.org; Tue, 30 Oct 2012 08:19:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTAnF-0004mf-MS for qemu-devel@nongnu.org; Tue, 30 Oct 2012 08:19:41 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9UCJeFe008542 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 30 Oct 2012 08:19:40 -0400 From: Juan Quintela In-Reply-To: <1350555758-29988-2-git-send-email-pbonzini@redhat.com> (Paolo Bonzini's message of "Thu, 18 Oct 2012 12:22:27 +0200") References: <1350555758-29988-1-git-send-email-pbonzini@redhat.com> <1350555758-29988-2-git-send-email-pbonzini@redhat.com> Date: Tue, 30 Oct 2012 13:19:37 +0100 Message-ID: <87y5iojgo6.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 01/12] migration: unify stdio-based QEMUFile operations Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Paolo Bonzini wrote: > Now that qemu_fseek does not exist anymore, there is no reason to do > an fseek before fread/fwrite when operating on an stdio file. > Thus, unify the get/put_buffer callbacks used by qemu_fopen > with those used for pipes. As far as I know, the pos parameter was only used by qcow2 to store the snapshots there. > > Signed-off-by: Paolo Bonzini Reviewed-by: Juan Quintela