From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THV4b-0000PN-R4 for qemu-devel@nongnu.org; Fri, 28 Sep 2012 03:33:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THV4X-0008EC-7x for qemu-devel@nongnu.org; Fri, 28 Sep 2012 03:33:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THV4W-0008Dw-W9 for qemu-devel@nongnu.org; Fri, 28 Sep 2012 03:33:17 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8S7XDbS031796 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 28 Sep 2012 03:33:13 -0400 From: Juan Quintela In-Reply-To: <50619979.4080206@redhat.com> (Orit Wasserman's message of "Tue, 25 Sep 2012 13:46:01 +0200") References: <1348217255-22441-1-git-send-email-quintela@redhat.com> <1348217255-22441-19-git-send-email-quintela@redhat.com> <50619979.4080206@redhat.com> Date: Fri, 28 Sep 2012 09:33:10 +0200 Message-ID: <87y5juob49.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 18/41] buffered_file: opaque is MigrationState Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: qemu-devel@nongnu.org Orit Wasserman wrote: > On 09/21/2012 11:47 AM, Juan Quintela wrote: >> It always have that type, just change it. >> -QEMUFile *qemu_fopen_ops_buffered(void *opaque, size_t xfer_limit, >> +QEMUFile *qemu_fopen_ops_buffered(MigrationState *migration_state, >> + size_t xfer_limit, >> BufferedPutFunc *put_buffer, >> BufferedPutReadyFunc *put_ready, >> BufferedWaitForUnfreezeFunc *wait_for_unfreeze, >> > Again why ? this is a general buffered file not just for migration use. It is not used for anything else. It is used only, and inlining it removes one level of indirection. All wins on my book. Notice that once the migration-thread patches end, this file basically dissapears (its only reason to exist was to allow non-blocking writes"). Later, Juan.