From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52096)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1T0x8t-0005VD-P2
	for qemu-devel@nongnu.org; Mon, 13 Aug 2012 12:05:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1T0x8s-0000gO-Bq
	for qemu-devel@nongnu.org; Mon, 13 Aug 2012 12:05:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11593)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1T0x8s-0000gA-3f
	for qemu-devel@nongnu.org; Mon, 13 Aug 2012 12:05:22 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7DG5L8R013580
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 13 Aug 2012 12:05:21 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <50291941.7020002@redhat.com> (Eric Blake's message of "Mon, 13
	Aug 2012 09:12:01 -0600")
References: <1344855057-32509-1-git-send-email-quintela@redhat.com>
	<1344855057-32509-8-git-send-email-quintela@redhat.com>
	<50291941.7020002@redhat.com>
Date: Mon, 13 Aug 2012 18:04:23 +0200
Message-ID: <87y5liwzg8.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 7/7] migration: Add dirty_pages_rate to
	query migrate output
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com

Eric Blake <eblake@redhat.com> wrote:
> On 08/13/2012 04:50 AM, Juan Quintela wrote:
>> For now this is a placeholder, real info will appear once the bitmap
>> changes in the migration thread series is integrated.
>> 
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>>  hmp.c            | 4 ++++
>>  migration.c      | 2 ++
>>  migration.h      | 1 +
>>  qapi-schema.json | 6 +++++-
>>  4 files changed, 12 insertions(+), 1 deletion(-)
>> 
>>  #
>> +# @dirty-pages-rate: number of pages dirtied by second by the
>> +#        guest. (since 1.2)
>
> Inconsistent on whether we have a '.' prior to the (since 1.2) marking.
>
> Since HMP only prints this stat when it is non-zero, should this field
> be marked optional?  Then again, once you have dirty page tracking, I
> suspect this would never be zero (or even showing an explicit zero would
> help detect stalls).

What is easier for libvirt to have here.

At the beggining, this value is going to be wrong/cero. I can:
- not print it until it is != 0
- print a big enough number )
- make it optional?  I guess this would alse be more difficult for
  libvirt.
- put your good idea here?

Later, Juan.