From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwgKb-0007tT-AR for qemu-devel@nongnu.org; Wed, 01 Aug 2012 17:19:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwgKZ-0007HF-SI for qemu-devel@nongnu.org; Wed, 01 Aug 2012 17:19:49 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:42475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwgKZ-0007H5-O7 for qemu-devel@nongnu.org; Wed, 01 Aug 2012 17:19:47 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 1 Aug 2012 17:19:46 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 08060C9003E for ; Wed, 1 Aug 2012 17:19:41 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q71LJedb363540 for ; Wed, 1 Aug 2012 17:19:40 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q71LJdDt003734 for ; Wed, 1 Aug 2012 17:19:39 -0400 From: Anthony Liguori In-Reply-To: <50199841.8020507@suse.de> References: <1343049748-11539-1-git-send-email-imammedo@redhat.com> <87zk6elisw.fsf@codemonkey.ws> <50195034.9050201@suse.de> <874nom8o5q.fsf@codemonkey.ws> <50198508.10303@suse.de> <87pq7acrdf.fsf@codemonkey.ws> <50199841.8020507@suse.de> Date: Wed, 01 Aug 2012 16:19:26 -0500 Message-ID: <87y5ly9uox.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: peter.maydell@linaro.org, ehabkost@redhat.com, gleb@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, Igor Mammedov Andreas F=C3=A4rber writes: > Am 01.08.2012 22:02, schrieb Anthony Liguori: >> Andreas F=C3=A4rber writes: >>=20 >>> Am 01.08.2012 20:25, schrieb Anthony Liguori: >>>> Andreas F=C3=A4rber writes: >>>> >>>>> Am 01.08.2012 17:43, schrieb Anthony Liguori: >>>>>> Igor Mammedov writes: >>>>>> >>>>>>> v2: >>>>>>> ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new= _cpu(), >>>>>>> to keep cpu_init implementation in -softmmu and -user targets the= same >>>>>>> in single place and maintanable. >>>>>>> >>>>>>> v3: >>>>>>> reuse cpu_is_bsp() rather than open code check if apicbase has BS= P bit set >>>>>>> >>>>>>> tree for testing: >>>>>>> https://github.com/imammedo/qemu/tree/x86_reset_v3 >>>>>>> >>>>>>> comiple & run tested with x86_64-linux-user, x86_64-softmmu targets >>>>>>> >>>>>>> Igor Mammedov (2): >>>>>>> target-i386: move cpu halted decision into x86_cpu_reset >>>>>>> target-i386: move cpu_reset and reset callback to cpu.c >>>>>> >>>>>> Applied all. Thanks. >>>>> >>>>> So do you intend to refactor all machines accordingly or leave it >>>>> inconsistent now? >>>> >>>> Are you asking me? >>>> >>>> No, I have no intention of touching any other machine. We're not going >>>> to limit cleaning up target-i386 unless every other machine is cleaned >>>> up too. >>>> >>>> Reset logic should live in the CPU. Seems like a no-brainer to me. >>> >>> Yes, I'm asking you, since you replied and applied the series without >>> responding to my review comment on patch 2/2. You probably applied it >>> locally before reading my comments but then I would still have expected >>> a reply on how to proceed in light of those comments: >>=20 >> No, I saw your comment, although I had already decided to apply it by >> then. > > If you did read it then you forgot my Reviewed-by on 1/2. :( Oh, sorry, I switched to a new patch apply script. Maybe it's not working correctly. I'll look into it. Regards, Anthony Liguori > > Andreas > > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg