From: "Alex Bennée" <alex.bennee@linaro.org>
To: Osama Abdelkader <osama.abdelkader@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org
Subject: Re: [PATCH] target/arm/cpu64: remove duplicate include
Date: Tue, 11 Nov 2025 11:47:42 +0000 [thread overview]
Message-ID: <87zf8srdsx.fsf@draig.linaro.org> (raw)
In-Reply-To: <20251110161552.700333-1-osama.abdelkader@gmail.com> (Osama Abdelkader's message of "Mon, 10 Nov 2025 18:15:52 +0200")
Osama Abdelkader <osama.abdelkader@gmail.com> writes:
> cpregs.h is included twice.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/arm/cpu64.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
> index f81cfd0113..ae84d8e420 100644
> --- a/target/arm/cpu64.c
> +++ b/target/arm/cpu64.c
> @@ -34,7 +34,6 @@
> #include "hw/qdev-properties.h"
> #include "internals.h"
> #include "cpu-features.h"
> -#include "cpregs.h"
>
> /* convert between <register>_IDX and SYS_<register> */
> #define DEF(NAME, OP0, OP1, CRN, CRM, OP2) \
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2025-11-11 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 16:15 [PATCH] target/arm/cpu64: remove duplicate include Osama Abdelkader
2025-11-11 11:47 ` Alex Bennée [this message]
2025-11-11 11:55 ` Gavin Shan
2025-11-14 13:04 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zf8srdsx.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=osama.abdelkader@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).