* [PATCH] target/arm/cpu64: remove duplicate include
@ 2025-11-10 16:15 Osama Abdelkader
2025-11-11 11:47 ` Alex Bennée
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Osama Abdelkader @ 2025-11-10 16:15 UTC (permalink / raw)
To: qemu-devel, qemu-arm, peter.maydell; +Cc: Osama Abdelkader
cpregs.h is included twice.
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
target/arm/cpu64.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
index f81cfd0113..ae84d8e420 100644
--- a/target/arm/cpu64.c
+++ b/target/arm/cpu64.c
@@ -34,7 +34,6 @@
#include "hw/qdev-properties.h"
#include "internals.h"
#include "cpu-features.h"
-#include "cpregs.h"
/* convert between <register>_IDX and SYS_<register> */
#define DEF(NAME, OP0, OP1, CRN, CRM, OP2) \
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] target/arm/cpu64: remove duplicate include
2025-11-10 16:15 [PATCH] target/arm/cpu64: remove duplicate include Osama Abdelkader
@ 2025-11-11 11:47 ` Alex Bennée
2025-11-11 11:55 ` Gavin Shan
2025-11-14 13:04 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2025-11-11 11:47 UTC (permalink / raw)
To: Osama Abdelkader; +Cc: qemu-devel, qemu-arm, peter.maydell
Osama Abdelkader <osama.abdelkader@gmail.com> writes:
> cpregs.h is included twice.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> target/arm/cpu64.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
> index f81cfd0113..ae84d8e420 100644
> --- a/target/arm/cpu64.c
> +++ b/target/arm/cpu64.c
> @@ -34,7 +34,6 @@
> #include "hw/qdev-properties.h"
> #include "internals.h"
> #include "cpu-features.h"
> -#include "cpregs.h"
>
> /* convert between <register>_IDX and SYS_<register> */
> #define DEF(NAME, OP0, OP1, CRN, CRM, OP2) \
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/arm/cpu64: remove duplicate include
2025-11-10 16:15 [PATCH] target/arm/cpu64: remove duplicate include Osama Abdelkader
2025-11-11 11:47 ` Alex Bennée
@ 2025-11-11 11:55 ` Gavin Shan
2025-11-14 13:04 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Gavin Shan @ 2025-11-11 11:55 UTC (permalink / raw)
To: Osama Abdelkader, qemu-devel, qemu-arm, peter.maydell
On 11/11/25 2:15 AM, Osama Abdelkader wrote:
> cpregs.h is included twice.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
> target/arm/cpu64.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Gavin Shan <gshan@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/arm/cpu64: remove duplicate include
2025-11-10 16:15 [PATCH] target/arm/cpu64: remove duplicate include Osama Abdelkader
2025-11-11 11:47 ` Alex Bennée
2025-11-11 11:55 ` Gavin Shan
@ 2025-11-14 13:04 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2025-11-14 13:04 UTC (permalink / raw)
To: Osama Abdelkader; +Cc: qemu-devel, qemu-arm
On Mon, 10 Nov 2025 at 16:15, Osama Abdelkader
<osama.abdelkader@gmail.com> wrote:
>
> cpregs.h is included twice.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-14 13:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-10 16:15 [PATCH] target/arm/cpu64: remove duplicate include Osama Abdelkader
2025-11-11 11:47 ` Alex Bennée
2025-11-11 11:55 ` Gavin Shan
2025-11-14 13:04 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).