From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
"Thomas Huth" <thuth@redhat.com>,
qemu-arm@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-ppc@nongnu.org, "Sai Pavan Boddu" <sai.pavan.boddu@amd.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v7 01/10] hw/qdev-properties-system: Introduce EndianMode QAPI enum
Date: Thu, 13 Feb 2025 11:07:10 +0100 [thread overview]
Message-ID: <87zfiqi2ep.fsf@pond.sub.org> (raw)
In-Reply-To: <20250212123659.52764-2-philmd@linaro.org> ("Philippe Mathieu-Daudé"'s message of "Wed, 12 Feb 2025 13:36:50 +0100")
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> Introduce the EndianMode type and the DEFINE_PROP_ENDIAN() macros.
> Endianness can be BIG, LITTLE or unspecified (default).
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> qapi/common.json | 16 ++++++++++++++++
> include/hw/qdev-properties-system.h | 7 +++++++
> hw/core/qdev-properties-system.c | 11 +++++++++++
> 3 files changed, 34 insertions(+)
>
> diff --git a/qapi/common.json b/qapi/common.json
> index 6ffc7a37890..33d8df19f67 100644
> --- a/qapi/common.json
> +++ b/qapi/common.json
> @@ -212,3 +212,19 @@
> ##
> { 'struct': 'HumanReadableText',
> 'data': { 'human-readable-text': 'str' } }
> +
> +##
> +# @EndianMode:
> +#
> +# An enumeration of three options: little, big, and unspecified
Not sure this sentence is worth its keep. It's consistent with existing
practice in this file, though.
> +#
> +# @unspecified: Endianness not specified
> +#
> +# @little: Little endianness
> +#
> +# @big: Big endianness
> +#
> +# Since: 10.0
> +##
> +{ 'enum': 'EndianMode',
> + 'data': [ 'unspecified', 'little', 'big' ] }
Acked-by: Markus Armbruster <armbru@redhat.com>
[...]
next prev parent reply other threads:[~2025-02-13 10:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 12:36 [PATCH v7 00/10] hw/microblaze: Allow running cross-endian vCPUs Philippe Mathieu-Daudé
2025-02-12 12:36 ` [PATCH v7 01/10] hw/qdev-properties-system: Introduce EndianMode QAPI enum Philippe Mathieu-Daudé
2025-02-13 10:07 ` Markus Armbruster [this message]
2025-02-12 12:36 ` [PATCH v7 02/10] hw/intc/xilinx_intc: Make device endianness configurable Philippe Mathieu-Daudé
2025-02-12 12:39 ` Philippe Mathieu-Daudé
2025-02-12 12:56 ` Thomas Huth
2025-02-13 12:15 ` Philippe Mathieu-Daudé
2025-02-12 12:36 ` [PATCH v7 03/10] hw/net/xilinx_ethlite: " Philippe Mathieu-Daudé
2025-02-12 13:01 ` Thomas Huth
2025-02-12 12:36 ` [PATCH v7 04/10] hw/timer/xilinx_timer: " Philippe Mathieu-Daudé
2025-02-12 13:04 ` Thomas Huth
2025-02-12 12:36 ` [PATCH v7 05/10] hw/char/xilinx_uartlite: " Philippe Mathieu-Daudé
2025-02-12 13:06 ` Thomas Huth
2025-02-12 12:36 ` [PATCH v7 06/10] hw/ssi/xilinx_spi: " Philippe Mathieu-Daudé
2025-02-12 13:10 ` Thomas Huth
2025-02-12 12:36 ` [PATCH v7 07/10] tests/functional: Explicit endianness of microblaze assets Philippe Mathieu-Daudé
2025-02-12 12:36 ` [PATCH v7 08/10] tests/functional: Allow microblaze tests to take a machine name argument Philippe Mathieu-Daudé
2025-02-12 12:36 ` [PATCH v7 09/10] tests/functional: Remove sleep() kludges from microblaze tests Philippe Mathieu-Daudé
2025-02-12 12:36 ` [PATCH v7 10/10] tests/functional: Have microblaze tests inherit common parent class Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfiqi2ep.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=berrange@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sai.pavan.boddu@amd.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).