From: Juan Quintela <quintela@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: peterx@redhat.com, isaku.yamahata@gmail.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] migration: refactor migration_completion
Date: Wed, 11 Oct 2023 13:22:44 +0200 [thread overview]
Message-ID: <87zg0pbdyz.fsf@secure.mitica> (raw)
In-Reply-To: <20230804093053.5037-1-wei.w.wang@intel.com> (Wei Wang's message of "Fri, 4 Aug 2023 17:30:53 +0800")
Wei Wang <wei.w.wang@intel.com> wrote:
> Current migration_completion function is a bit long. Refactor the long
> implementation into different subfunctions:
> - migration_completion_precopy: completion code related to precopy
> - migration_completion_postcopy: completion code related to postcopy
> - close_return_path_on_source: rp thread related cleanup on migration
> completion. It is named to match with open_return_path_on_source.
>
> This improves readability and is easier for future updates (e.g. add new
> subfunctions when completion code related to new features are needed). No
> functional changes intended.
>
> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued.
next prev parent reply other threads:[~2023-10-11 11:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 9:30 [PATCH v2] migration: refactor migration_completion Wei Wang
2023-08-04 13:37 ` Peter Xu
2023-10-11 9:03 ` Wang, Wei W
2023-08-14 22:14 ` Isaku Yamahata
2023-10-11 11:22 ` Juan Quintela [this message]
2023-10-11 12:41 ` Juan Quintela
2023-10-11 14:45 ` Wang, Wei W
2023-10-11 20:31 ` Juan Quintela
2023-10-12 14:36 ` Wang, Wei W
2023-10-12 14:43 ` Wang, Wei W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg0pbdyz.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=isaku.yamahata@gmail.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).