From: Juan Quintela <quintela@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, jsnow@redhat.com,
crosa@redhat.com, kwolf@redhat.com, hreitz@redhat.com,
eblake@redhat.com, "Daniel P . Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Joel Stanley" <joel@jms.id.au>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Peter Xu" <peterx@redhat.com>, "Fabiano Rosas" <farosas@suse.de>,
"Leonardo Bras" <leobras@redhat.com>,
qemu-arm@nongnu.org (open list:Integrator CP),
qemu-s390x@nongnu.org (open list:S390 Virtio-ccw)
Subject: Re: [PATCH v7 05/15] python/qemu: rename command() to cmd()
Date: Mon, 09 Oct 2023 11:52:37 +0200 [thread overview]
Message-ID: <87zg0syvfe.fsf@secure.mitica> (raw)
In-Reply-To: <20231006154125.1068348-6-vsementsov@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Fri, 6 Oct 2023 18:41:15 +0300")
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> Use a shorter name. We are going to move in iotests from qmp() to
> command() where possible. But command() is longer than qmp() and don't
> look better. Let's rename.
I feel your pain O:-)
> You can simply grep for '\.command(' and for 'def command(' to check
> that everything is updated (command() in tests/docker/docker.py is
> unrelated).
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> [vsementsov: also update three occurrences in
> tests/avocado/machine_aspeed.py and keep r-b]
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2023-10-09 9:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 15:41 [PATCH v7 00/15] iotests: use vm.cmd() Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 01/15] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 02/15] qmp_shell.py: _fill_completion() use .command() instead of .cmd() Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 03/15] scripts/cpu-x86-uarch-abi.py: " Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 04/15] python: rename QEMUMonitorProtocol.cmd() to cmd_raw() Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 05/15] python/qemu: rename command() to cmd() Vladimir Sementsov-Ogievskiy
2023-10-09 8:17 ` Cédric Le Goater
2023-10-09 9:52 ` Juan Quintela [this message]
2023-10-06 15:41 ` [PATCH v7 06/15] python/machine.py: upgrade vm.cmd() method Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 07/15] iotests: QemuStorageDaemon: add cmd() method like in QEMUMachine Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 08/15] iotests: add some missed checks of qmp result Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 09/15] iotests: refactor some common qmp result checks into generic pattern Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 10/15] iotests: drop some extra semicolons Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 11/15] iotests: drop some extra ** in qmp() call Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 12/15] iotests.py: pause_job(): drop return value Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 13/15] tests/vm/basevm.py: use cmd() instead of qmp() Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 14/15] scripts: add python_qmp_updater.py Vladimir Sementsov-Ogievskiy
2023-10-06 17:01 ` Eric Blake
2023-10-06 17:42 ` Vladimir Sementsov-Ogievskiy
2023-10-06 15:41 ` [PATCH v7 15/15] python: use vm.cmd() instead of vm.qmp() where appropriate Vladimir Sementsov-Ogievskiy
2023-10-06 17:05 ` Eric Blake
2023-10-11 22:04 ` [PATCH v7 00/15] iotests: use vm.cmd() John Snow
2023-10-12 17:52 ` Vladimir Sementsov-Ogievskiy
2023-10-12 18:21 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg0syvfe.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=andrew@aj.id.au \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@kaod.org \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=farman@linux.ibm.com \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=joel@jms.id.au \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=leobras@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).