From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1F2EE7C4D0 for ; Wed, 4 Oct 2023 15:25:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qo3kG-0003vP-68; Wed, 04 Oct 2023 11:25:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qo3kD-0003r4-0H for qemu-devel@nongnu.org; Wed, 04 Oct 2023 11:25:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qo3k3-00077F-Qv for qemu-devel@nongnu.org; Wed, 04 Oct 2023 11:25:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696433090; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=9KXvSUCAOG8VA6NjKjJ4sNdXf8D0mbCa1jU4QfUjklw=; b=af/GIIkrPVMeuY4IIcZhNAS0koTATUcSMkCIHPQmzrkTyg6qwmMvCdSskR/bcBJv6UfRFz gWmTxUikdDvWHW+kBfT5UiqcI3+ZiZnGh0LWkSAAU+ujO6nxUqReN7Q4a8YHHaaruG0sOk +NrHOHTRJxupJljh8s6WQOBB0KCahV4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-h4i9xhw5Oc-esch_3ujD2g-1; Wed, 04 Oct 2023 11:24:49 -0400 X-MC-Unique: h4i9xhw5Oc-esch_3ujD2g-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4030ae94fedso16549445e9.1 for ; Wed, 04 Oct 2023 08:24:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696433088; x=1697037888; h=mime-version:message-id:date:reply-to:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9KXvSUCAOG8VA6NjKjJ4sNdXf8D0mbCa1jU4QfUjklw=; b=WBKFgzaDwQxIBDjnYG6JlKyYdHhr1WB2usF29J/PQb2llbmn0i0PyBEjSKKiUXO1pc umKAwmvBPKp0sPmVFGTERGVko6GlfrLw1utswXEe620jzmXJyKzfqNImr94FZ0bwfYHc grCDIFDF2eOXkkVklsvqg3gd3FRD4J+M64JYPXbcCcj0wh8Yg8AgvrMbpBAS/YhWEKDc MhqT5R7Jdkr939eeFhALReFIQs2g2yZQ0wSHWmdmz6uShy5EnWoJIJ7Rrq4PdN9W3//h xeWiOz/p4RoysV6/9SbNDVzKsYULN/x7SRQUnVfM6RxFLoLZkuTEHRPJUBbhuAXwgbMa dqYQ== X-Gm-Message-State: AOJu0YyESg+JhdyoKzGoAiei9K9QlhCXVKa7q9npfabfUWGkLLCxQNQh OAIpMbCC0nYIbMT6y4+cX+FJzaINbWOGzksbVsQ21zH+TMEwPF7ar9hQbldmxZiZ1IhTYYGJo1g 800HH2ghKCjzv+NE= X-Received: by 2002:a1c:720a:0:b0:401:b6f6:d90c with SMTP id n10-20020a1c720a000000b00401b6f6d90cmr2725607wmc.35.1696433087898; Wed, 04 Oct 2023 08:24:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGvYDnHIh94vpeuUQdP3ZLxfPvdGvaIfJ4A54B6LMP6/F3v1pQo/gbGvs0MX0vt3Cpp5DvyrQ== X-Received: by 2002:a1c:720a:0:b0:401:b6f6:d90c with SMTP id n10-20020a1c720a000000b00401b6f6d90cmr2725589wmc.35.1696433087525; Wed, 04 Oct 2023 08:24:47 -0700 (PDT) Received: from redhat.com (static-151-150-85-188.ipcom.comunitel.net. [188.85.150.151]) by smtp.gmail.com with ESMTPSA id k16-20020a05600c0b5000b00403bbe69629sm1792413wmr.31.2023.10.04.08.24.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 08:24:47 -0700 (PDT) From: Juan Quintela To: Markus Armbruster Cc: qemu-devel@nongnu.org, peterx@redhat.com, leobras@redhat.com, farosas@suse.de, lizhijian@fujitsu.com, eblake@redhat.com Subject: Re: [PATCH v2 22/53] migration/rdma: Drop dead qemu_rdma_data_init() code for !@host_port In-Reply-To: <20230928132019.2544702-23-armbru@redhat.com> (Markus Armbruster's message of "Thu, 28 Sep 2023 15:19:48 +0200") References: <20230928132019.2544702-1-armbru@redhat.com> <20230928132019.2544702-23-armbru@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Date: Wed, 04 Oct 2023 17:24:46 +0200 Message-ID: <87zg0ywgu9.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Markus Armbruster wrote: > qemu_rdma_data_init() neglects to set an Error when it fails because > @host_port is null. Fortunately, no caller passes null, so this is > merely a latent bug. Drop the flawed code handling null argument. > > Signed-off-by: Markus Armbruster Reviewed-by: Juan Quintela As your discussion with Peter, I think that this is ok. The only other thing we could do is add an assert(), but I am not a big fan either.