qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-arm@nongnu.org, Shashi Mallela <shashi.mallela@linaro.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/intc/arm_gicv3_its: Avoid maybe-uninitialized error in get_vte()
Date: Thu, 31 Aug 2023 14:43:49 +0100	[thread overview]
Message-ID: <87zg27nx7p.fsf@linaro.org> (raw)
In-Reply-To: <20230831131348.69032-1-philmd@linaro.org>


Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Fix when using GCC v11.4 (Ubuntu 11.4.0-1ubuntu1~22.04) with CFLAGS=-Og:
>
>   [4/6] Compiling C object libcommon.fa.p/hw_intc_arm_gicv3_its.c.o
>   FAILED: libcommon.fa.p/hw_intc_arm_gicv3_its.c.o
>       inlined from ‘lookup_vte’ at hw/intc/arm_gicv3_its.c:453:9,
>       inlined from ‘vmovp_callback’ at hw/intc/arm_gicv3_its.c:1039:14:
>   hw/intc/arm_gicv3_its.c:347:9: error: ‘vte.rdbase’ may be used uninitialized [-Werror=maybe-uninitialized]
>     347 |         trace_gicv3_its_vte_read(vpeid, vte->valid, vte->vptsize,
>         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     348 |                                  vte->vptaddr, vte->rdbase);
>         |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~
>   hw/intc/arm_gicv3_its.c: In function ‘vmovp_callback’:
>   hw/intc/arm_gicv3_its.c:1036:13: note: ‘vte’ declared here
>    1036 |     VTEntry vte;
>         |             ^~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  reply	other threads:[~2023-08-31 13:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 13:13 [PATCH] hw/intc/arm_gicv3_its: Avoid maybe-uninitialized error in get_vte() Philippe Mathieu-Daudé
2023-08-31 13:43 ` Alex Bennée [this message]
2023-09-08 11:58 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg27nx7p.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shashi.mallela@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).