From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9320AEB64D7 for ; Mon, 26 Jun 2023 20:24:07 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDsjz-00035F-9U; Mon, 26 Jun 2023 16:23:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDsjw-00033l-TQ for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:23:12 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDsju-0004bo-DP for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:23:12 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-31297125334so3263933f8f.0 for ; Mon, 26 Jun 2023 13:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687810988; x=1690402988; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=Oh7orIRxmqAh9touFfIQ3i81Vq6+d6bKsd0MmZRWUFE=; b=ZFWzYW3JVsSTnWB98K1Eg9az/UgnELKL/7gnktU/PpEMxPJyx4wewe0M3D/tjFRcsp zDjpWRUpGP0uIz0Uv73CZ0y8A6TjcVVF2p4pTpV89tl0wyWvz2Becf+o7xSpYSmijl+S S3JyOXMOgeX3TzHQid2lEq9wMAuVPUwema9/0Z4pF5+rtUXtyVn5365r/Lzuej/U7kDN DvxK8fQ8CohsWsBmeZPobjlksCV7KSWo6mxmuTQJSRZAEyHjemWSi8VEAqkCN248VifY 26OO1Xx87ZBh2BKRnSucNZXxLh9ifGzfUzcXu1QepsFDLBbSpzf+e+rsj0eKU7QCkyFa Ob4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687810988; x=1690402988; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Oh7orIRxmqAh9touFfIQ3i81Vq6+d6bKsd0MmZRWUFE=; b=LxYI26lD3YYmi7jruCc4bZ1GbyXxAEoLAej9P8Iy4PMS4laW/4BG/jvxybDlbzYSoC jMpngWFGfhcSayopRx7G+4nXYZqLEMaGR0t7A4Ho4HPrrLG7DGBmzSRoNKSI933618T3 ncigZLvRZc1YNn9upBbotNTw/v2I+6gDBvDff+Sp0rg6lCIJEDaTrbLK0BZ6uk0SCTrU wq8zutqm+I82Gg/Fcg66BzZ58WeAtHskG7kWHP34hK68Htr4NBwiNhGVzEn/BXAYFunR 43UbGVtimAzv0zprntuoZSXWgWk1tN7eJP0DrYOyBYo9w3VDvMC5LfKRXiHmd8lYAwz6 1LZw== X-Gm-Message-State: AC+VfDy2uc1z9KHBbXXwmxCsNuAeCXP2dpiOHWDiH0D8AxqqxRsxIQlz 7ZlO5Gj/Hnnv6C80k4AsY+82xA== X-Google-Smtp-Source: ACHHUZ7fQpa4969tiXnoT6HgwW2GpyBFDSsIxueIHdewArHlGcJPFRRphW8/Ali/DuQoTHMtK5StXQ== X-Received: by 2002:a5d:45c9:0:b0:313:e88d:e6d3 with SMTP id b9-20020a5d45c9000000b00313e88de6d3mr6429956wrs.14.1687810988572; Mon, 26 Jun 2023 13:23:08 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id j9-20020a5d4649000000b0031118d80246sm8278477wrs.29.2023.06.26.13.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 13:23:08 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7DB6E1FFBB; Mon, 26 Jun 2023 21:23:07 +0100 (BST) References: <20230623122100.1640995-1-alex.bennee@linaro.org> <20230623122100.1640995-8-alex.bennee@linaro.org> User-agent: mu4e 1.11.7; emacs 29.0.92 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Peter Maydell Cc: qemu-devel@nongnu.org, Richard Henderson , Juan Quintela , Cleber Rosa , Darren Kenny , Alexandre Iooss , Peter Xu , qemu-arm@nongnu.org, Eduardo Habkost , Riku Voipio , Mahmoud Mandour , =?utf-8?Q?Daniel_P=2E_Berrang?= =?utf-8?Q?=C3=A9?= , Paolo Bonzini , Bandan Das , Marcin Juszkiewicz , Radoslaw Biernacki , Alexander Bulekov , Leif Lindholm , Qiuhao Li , Wainer dos Santos Moschetta , Marcel Apfelbaum , Leonardo Bras , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Bin Meng , Thomas Huth , Beraldo Leal , Laurent Vivier , Yanan Wang Subject: Re: [PATCH 07/26] qemu-keymap: properly check return from xkb_keymap_mod_get_index Date: Mon, 26 Jun 2023 21:21:14 +0100 In-reply-to: Message-ID: <87zg4m0y8k.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Maydell writes: > On Fri, 23 Jun 2023 at 13:21, Alex Benn=C3=A9e w= rote: >> >> We can return XKB_MOD_INVALID which rightly gets flagged by sanitisers >> as an overly wide shift attempt. >> >> Signed-off-by: Alex Benn=C3=A9e > > Same comments as on the first version of this patch: > looks OK code-wise, but have you eyeballed the output? I've eyeballed it but practically it doesn't seem to make any difference to the output: =F0=9F=95=9921:20:36 alex@zen:qemu.git/builds/all (399fc0c) (REBASING 2/= 22) [$!?]=20 =E2=9E=9C diff -ub gb.before gb.after =F0=9F=95=9921:20:43 alex@zen:qemu.git/builds/all (399fc0c) (REBASING 2/= 22) [$!?]=20 =E2=9E=9C diff -ub ara.before ara.after > Does the keyboard layout that triggers this have no > AltGr at all, or does it call it by a different name? Certainly not ara or gb: 9: Alt 23:# 11: LAlt 24:# 12: RAlt 29:# 17: AltGr 294:Alt_L 0x38 1711:Alt_R 0xb8 =F0=9F=95=9921:22:14 alex@zen:qemu.git/builds/all (399fc0c) (REBASING 2/22= ) [$!?]=20 =E2=9E=9C ag "Alt" gb.after=20 21:# 9: Alt 23:# 11: LAlt 24:# 12: RAlt 29:# 17: AltGr 338:Alt_L 0x38 1757:Alt_R 0xb8 > > thanks > -- PMM --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro