From: Juan Quintela <quintela@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v1 2/6] tests/qtest/migration-test: Only wait for serial output where migration succeeds
Date: Mon, 22 Aug 2022 23:14:08 +0200 [thread overview]
Message-ID: <87zgfwyo9r.fsf@secure.mitica> (raw)
In-Reply-To: <20220822165608.2980552-3-alex.bennee@linaro.org> ("Alex Bennée"'s message of "Mon, 22 Aug 2022 17:56:04 +0100")
Alex Bennée <alex.bennee@linaro.org> wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> Waiting for the serial output can take a couple of seconds - and since
> we're doing a lot of migration tests, this time easily sums up to
> multiple minutes. But if a test is supposed to fail, it does not make
> much sense to wait for the source to be in the right state first, so
> we can skip the waiting here. This way we can speed up all tests where
> the migration is supposed to fail. In the gitlab-CI gprov-gcov test,
> each of the migration-tests now run two minutes faster!
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> Message-Id: <20220819053802.296584-2-thuth@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2022-08-22 21:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 16:56 [PATCH for 7.1 v1 0/6] testing fixes and doc tweak pre-PR Alex Bennée
2022-08-22 16:56 ` [PATCH v1 1/6] tests/avocado: push default timeout to QemuBaseTest Alex Bennée
2022-08-22 20:50 ` Richard Henderson
2022-08-25 14:11 ` Philippe Mathieu-Daudé via
2022-08-22 16:56 ` [PATCH v1 2/6] tests/qtest/migration-test: Only wait for serial output where migration succeeds Alex Bennée
2022-08-22 21:14 ` Juan Quintela [this message]
2022-08-22 16:56 ` [PATCH v1 3/6] tests/migration/aarch64: Speed up the aarch64 migration test Alex Bennée
2022-08-22 16:56 ` [PATCH v1 4/6] tests/migration/i386: Speed up the i386 migration test (when using TCG) Alex Bennée
2022-08-22 16:56 ` [PATCH v1 5/6] tests/qtest/migration-test: Remove duplicated test_postcopy from the test plan Alex Bennée
2022-08-22 21:26 ` Juan Quintela
2022-08-22 16:56 ` [PATCH v1 6/6] qemu-options: try and clarify preferred block semantics Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgfwyo9r.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).