From: Cornelia Huck <cohuck@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org
Subject: Re: [PATCH for-6.2 3/6] s390-sclp-events-bus: Set instance_size
Date: Fri, 06 Aug 2021 13:44:13 +0200 [thread overview]
Message-ID: <87zgtuyf02.fsf@redhat.com> (raw)
In-Reply-To: <20210805193431.307761-4-ehabkost@redhat.com>
On Thu, Aug 05 2021, Eduardo Habkost <ehabkost@redhat.com> wrote:
> We have a SCLPEventsBus struct defined, but the struct is not
> used at the TypeInfo definition. This works today but will break
> silently if anybody adds a new field to SCLPEventsBus.
>
> Set instance_size properly to avoid problems in the future.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Halil Pasic <pasic@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: qemu-s390x@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
> hw/s390x/event-facility.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
(I assume that you'll queue the whole series yourself? Or should we pick
the s390x parts separately?)
next prev parent reply other threads:[~2021-08-06 11:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 19:34 [PATCH for-6.2 0/6] qom: Fix broken OBJECT_CHECK usage Eduardo Habkost
2021-08-05 19:34 ` [PATCH for-6.2 1/6] acpi: Delete broken ACPI_GED_X86 macro Eduardo Habkost
2021-08-06 10:42 ` Igor Mammedov
2021-08-09 10:52 ` Gerd Hoffmann
2021-08-05 19:34 ` [PATCH for-6.2 2/6] sbsa_gwdt: Delete broken SBSA_*CLASS macros Eduardo Habkost
2021-08-05 19:34 ` [PATCH for-6.2 3/6] s390-sclp-events-bus: Set instance_size Eduardo Habkost
2021-08-06 4:16 ` Thomas Huth
2021-08-06 6:54 ` David Hildenbrand
2021-08-06 11:44 ` Cornelia Huck [this message]
2021-08-05 19:34 ` [PATCH for-6.2 4/6] s390-sclp-events-bus: Use OBJECT_DECLARE_SIMPLE_TYPE Eduardo Habkost
2021-08-06 2:43 ` Eduardo Habkost
2021-08-06 2:46 ` [PATCH for-6.2 v2] " Eduardo Habkost
2021-08-06 4:14 ` Thomas Huth
2021-08-06 6:54 ` David Hildenbrand
2021-08-06 11:45 ` Cornelia Huck
2021-08-05 19:34 ` [PATCH for-6.2 5/6] s390x: event-facility: Use SCLP_EVENT_BUS macro Eduardo Habkost
2021-08-06 4:15 ` Thomas Huth
2021-08-06 6:54 ` David Hildenbrand
2021-08-06 11:47 ` Cornelia Huck
2021-08-05 19:34 ` [PATCH for-6.2 6/6] Use PCI_HOST_BRIDGE macro Eduardo Habkost
2021-08-06 11:01 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgtuyf02.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).