From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Aaron Lindsay <aaron@os.amperecomputing.com>,
"Emilio G. Cota" <cota@braap.org>,
Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: Plugin Address Translations Inconsistent/Incorrect?
Date: Tue, 23 Feb 2021 08:52:45 +0000 [thread overview]
Message-ID: <87zgzv4108.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA81B_7+aEu3CkOwRGdaEtP8r_HwihuD+oEwYsb4+ZmSUA@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On Mon, 22 Feb 2021 at 19:53, Alex Bennée <alex.bennee@linaro.org> wrote:
>> It certainly is by design. The comment for the helper states:
>>
>> /*
>> * The following additional queries can be run on the hwaddr structure
>> * to return information about it. For non-IO accesses the device
>> * offset will be into the appropriate block of RAM.
>> */
>
> That sounds like we're exposing ram_addrs to the plugin. Are we?
> I'm not sure that's a good idea, as they're not a guest-relevant
> construct.
We currently expose qemu_ram_addr_from_host for RAM blocks. Are you
saying we should translate that to the direct physical address mapping?
If we do that for RAM should we be doing the same for IO addresses?
>
> thanks
> -- PMM
--
Alex Bennée
next prev parent reply other threads:[~2021-02-23 8:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 17:07 Plugin Address Translations Inconsistent/Incorrect? Aaron Lindsay
2021-02-22 19:30 ` Alex Bennée
2021-02-22 20:08 ` Peter Maydell
2021-02-23 8:52 ` Alex Bennée [this message]
2021-02-23 10:55 ` Peter Maydell
2021-02-22 20:48 ` Aaron Lindsay via
2021-02-23 20:53 ` Aaron Lindsay via
2021-03-02 15:33 ` Aaron Lindsay via
2021-03-02 16:06 ` Alex Bennée
2021-03-02 19:41 ` Aaron Lindsay via
2021-03-02 21:04 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgzv4108.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aaron@os.amperecomputing.com \
--cc=cota@braap.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).