From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17E3CC433E0 for ; Tue, 9 Feb 2021 20:52:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 906B264E5A for ; Tue, 9 Feb 2021 20:52:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 906B264E5A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9ZzO-0001sg-Ho for qemu-devel@archiver.kernel.org; Tue, 09 Feb 2021 15:52:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9Zwy-0000H4-1h for qemu-devel@nongnu.org; Tue, 09 Feb 2021 15:49:35 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:33792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9Zwr-0001SL-Rl for qemu-devel@nongnu.org; Tue, 09 Feb 2021 15:49:29 -0500 Received: by mail-wr1-x42b.google.com with SMTP id g10so23757873wrx.1 for ; Tue, 09 Feb 2021 12:49:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=C8V1I+9L7vEv2Tps2EOF9y4VG+73pNSCbbVcEIPmE38=; b=BXATaGZ9Z8MUqbH3959KhBQcYauy0e9sfI2Vi7I5fxagTA+ErUqp9GZqGuHzOUq2IR 3I2Cw73SfJyd6eOhoOggj4DXL7MPUOai+Gkly/uchepOOHjPp6wHNBU4iUcWk6EmNOig WGH/zn1vfpwbuOCh1vKjyzF1ensGmJScGNWEnRc8ODP1QdMAnD64Q40oLHydRBfpHWuC TjMJmJrc/l672x759kRtfOIXcjtmdrXLl0orhZTGZFaIyHpPsgz5pWiyD8OusuIyFhDN vYNilTLhy8MwGncH9Uwv5jqtWce2XCze92slHM/jz9t56pT/zUkl+AkZZYbF9IJv3kCD 1JLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=C8V1I+9L7vEv2Tps2EOF9y4VG+73pNSCbbVcEIPmE38=; b=Qvef6CuxCvk43SEid7z7fRJnUNSNbZ/O0aobAsbaTsf9LZPX6hMYN5XZ7/cY9G6SO6 BdV5/Ld0Tl7hLpiByCEiW71w6E9yJiqjesqdQglbj7PZRJp5e7LAZx2zY/sXwgeXcAsM QnIhjYhsDdmo8aZNC0uYvDiqgdTrJHPxLj7AxunEhCOr+FeTBUZRHKGYRUuHpRPrRJyR XCM2TvFQ1b00vsQyI84TlfnsKa+flHKhWtje+4E6spT01eWUy5D6MZzBvbmwACKsl6ey aMKLCDwWxqIeL1zl80Qzld7iPjADFpl3oRxHSL6tfppK0KR7bGq/oSup9M6q5YPGejIn 0tPw== X-Gm-Message-State: AOAM5321YipRT9sDMhpHzeSA3PaAaFIWMj0PFAaNoHJ3MBMg5CYOnNTN KX3j13TaCLi6XLT49UZJVpTE4g== X-Google-Smtp-Source: ABdhPJyTxoQA/4XhP5vBR5+qZlQq+ZSdVIRX4f6/ld696CTspiPRWB9dSdk/JfPEg5J2DfL65CntOg== X-Received: by 2002:adf:e4c3:: with SMTP id v3mr26082629wrm.210.1612903763801; Tue, 09 Feb 2021 12:49:23 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id l11sm36068133wrt.23.2021.02.09.12.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 12:49:22 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 881D31FF7E; Tue, 9 Feb 2021 20:49:21 +0000 (GMT) References: <20210209182749.31323-1-alex.bennee@linaro.org> <20210209182749.31323-6-alex.bennee@linaro.org> <68de96f4-b3ff-d975-5055-2ba60cd8576d@linaro.org> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Richard Henderson Subject: Re: [PATCH v1 05/12] tests/plugin: expand insn test to detect duplicate instructions Date: Tue, 09 Feb 2021 20:48:42 +0000 In-reply-to: <68de96f4-b3ff-d975-5055-2ba60cd8576d@linaro.org> Message-ID: <87zh0d7yr2.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kuhn.chenqun@huawei.com, aaron@os.amperecomputing.com, cota@braap.org, qemu-devel@nongnu.org, robhenry@microsoft.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Richard Henderson writes: > On 2/9/21 10:27 AM, Alex Benn=C3=A9e wrote: >> A duplicate insn is one that is appears to be executed twice in a row. >> This is currently possible due to -icount and cpu_io_recompile() >> causing a re-translation of a block. On it's own this won't trigger >> any tests though. >>=20 >> Signed-off-by: Alex Benn=C3=A9e >>=20 >> --- >> [AJB: well not quite, the x86_64 test trips over this due to some >> weirdness in the way we handle rep insns, e.g. rep movsb (%esi), >> %es:(%edi) in the x86 bios code] > > Ah, but that's not tcg weirdness, that's architectural weirdness. Multip= le > executions is how "rep" is supposed to work. As the plugin can know the arch I can just disable the test for x86. At the moment it doesn't matter because there is only a test for aarch64. --=20 Alex Benn=C3=A9e