From: "Alex Bennée" <alex.bennee@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>
Cc: peter.maydell@linaro.org, Richard Henderson <rth@twiddle.net>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PULL v2 05/13] accel/tcg: Relax va restrictions on 64-bit guests
Date: Thu, 04 Jun 2020 18:31:24 +0100 [thread overview]
Message-ID: <87zh9i4u1f.fsf@linaro.org> (raw)
In-Reply-To: <843d72a9-22a7-b0b5-0a92-edf1dcd290d2@vivier.eu>
Laurent Vivier <laurent@vivier.eu> writes:
> On 15/05/2020 16:43, Alex Bennée wrote:
>> From: Richard Henderson <richard.henderson@linaro.org>
>>
>> We cannot at present limit a 64-bit guest to a virtual address
>> space smaller than the host. It will mostly work to ignore this
>> limitation, except if the guest uses high bits of the address
>> space for tags. But it will certainly work better, as presently
>> we can wind up failing to allocate the guest stack.
>>
>> Widen our user-only page tree to the host or abi pointer width.
>> Remove the workaround for this problem from target/alpha.
>> Always validate guest addresses vs reserved_va, as there we
>> control allocation ourselves.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>
>> Message-Id: <20200513175134.19619-7-alex.bennee@linaro.org>
>>
>
> This patch breaks a test case in LTP with 64bit targets on x86_64 host:
>
> sudo linux-user/mips64el-linux-user/qemu-mips64el \
> -L chroot/mips64el/stretch/ \
> chroot/mips64el/stretch/opt/ltp/testcases/bin/mmap15
>
> qemu-mips64el: accel/tcg/translate-all.c:2533: page_set_flags: Assertion
> `start < end' failed.
> qemu:handle_cpu_signal received signal outside vCPU context @
> pc=0x7f0015f6e7cb
>
> Could you have a look?
Can confirm I've replicated:
18:30:20 [alex.bennee@hackbox2:~/l/q/b/user.static] next/various-fixes|✔ 32 +
sudo ./mips64el-linux-user/qemu-mips64el -L ~/lsrc/buildroot.git/builds/mips64el/target/ ~/lsrc/buildroot.git/builds/mips64el/target/usr/lib/ltp-testsuite/testcases/bin/mmap
15
[sudo] password for alex.bennee:
qemu-mips64el: /home/alex.bennee/lsrc/qemu.git/accel/tcg/translate-all.c:2533: page_set_flags: Assertion `start < end' failed.
qemu:handle_cpu_signal received signal outside vCPU context @ pc=0x6c28c2
Also TIL you can use buildroot to build ltp ;-)
>
> Thanks,
> Laurent
--
Alex Bennée
next prev parent reply other threads:[~2020-06-04 17:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 14:43 [PULL v2 00/13] testing, tcg and plugin updates Alex Bennée
2020-05-15 14:43 ` [PULL v2 01/13] tests/guest-debug: catch hanging guests Alex Bennée
2020-05-15 14:43 ` [PULL v2 02/13] travis.yml: Improve the --disable-tcg test on s390x Alex Bennée
2020-05-15 14:43 ` [PULL v2 03/13] linux-user: completely re-write init_guest_space Alex Bennée
2020-05-15 14:43 ` [PULL v2 04/13] exec/cpu-all: Use bool for have_guest_base Alex Bennée
2020-05-15 14:43 ` [PULL v2 05/13] accel/tcg: Relax va restrictions on 64-bit guests Alex Bennée
2020-06-04 14:15 ` Laurent Vivier
2020-06-04 17:31 ` Alex Bennée [this message]
2020-06-05 14:11 ` Alex Bennée
2020-06-05 17:38 ` Richard Henderson
2020-06-05 17:46 ` Alex Bennée
2020-06-05 18:26 ` Richard Henderson
2020-05-15 14:43 ` [PULL v2 06/13] accel/tcg: don't disable exec_tb trace events Alex Bennée
2020-05-15 14:43 ` [PULL v2 07/13] disas: include an optional note for the start of disassembly Alex Bennée
2020-05-15 14:44 ` [PULL v2 08/13] disas: add optional note support to cap_disas Alex Bennée
2020-05-15 14:44 ` [PULL v2 09/13] translate-all: include guest address in out_asm output Alex Bennée
2020-05-15 14:44 ` [PULL v2 10/13] qemu/plugin: Trivial code movement Alex Bennée
2020-05-15 14:44 ` [PULL v2 11/13] qemu/plugin: Move !CONFIG_PLUGIN stubs altogether Alex Bennée
2020-05-15 14:44 ` [PULL v2 12/13] qemu/qemu-plugin: Make qemu_plugin_hwaddr_is_io() hwaddr argument const Alex Bennée
2020-05-15 14:44 ` [PULL v2 13/13] MAINTAINERS: update the orphaned cpus-common.c file Alex Bennée
2020-05-15 15:46 ` [PULL v2 00/13] testing, tcg and plugin updates Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh9i4u1f.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).