From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FDCFC2D0DB for ; Mon, 20 Jan 2020 14:43:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 471BD217F4 for ; Mon, 20 Jan 2020 14:43:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZE7zrGVf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 471BD217F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itYGm-0002Zz-3m for qemu-devel@archiver.kernel.org; Mon, 20 Jan 2020 09:43:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42017) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itY7o-0008N6-IF for qemu-devel@nongnu.org; Mon, 20 Jan 2020 09:33:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itY7n-0005tn-Cd for qemu-devel@nongnu.org; Mon, 20 Jan 2020 09:33:56 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:46395) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itY7n-0005tF-65 for qemu-devel@nongnu.org; Mon, 20 Jan 2020 09:33:55 -0500 Received: by mail-wr1-x443.google.com with SMTP id z7so29753990wrl.13 for ; Mon, 20 Jan 2020 06:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=OrS29nHuqMvog06bNTk5Jqed9OQgl9PaFnJbYfvAjnY=; b=ZE7zrGVfMqUuvxgfX8w5Tl1MXfsO4e+66EQkgYLSbE3CIN0ICdHq05iYVdZi696U6+ NE8hm+jGSMEBF6syoNEzj6ffplTMNzine/Nb/iHKajG+ms1TFPHNHwYdJlChXt+9DnsA kyvcvEL+r7bPSkvdiZdDsS4f7VUULLdRRE32VRjvY57TVbLjVk74wnM7i0S4wgvfZCfr k7tilzhuCa06zBDYRABqV936mNOUHgJTPnMA7mYDAssje3n5b/ThcpE6jI1SPxlVgBaa Dz1WEHd/KJyhSEOaP014O6Q+wEbqDAWdnFzAZcCNUEg7noOtxEa7R/s57MAqMHWdtLp/ c0QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=OrS29nHuqMvog06bNTk5Jqed9OQgl9PaFnJbYfvAjnY=; b=RBPUiiv3NBnKr8fVUUWRLFvRz7c5wT6uTcL++UncqbM8elqBAa/k1MmsB5N3Lr3ER9 9/yzWHfkc/+28Vm3AkD+Yf1x+b7hcw/D8/kKgbn7XO11hY/KYUoi6yYeYjc3/QjnXvZK Ti/3mIGebY0AYMZw4PE311UsuZmC/XTBqiujoLfwmrGBI8RiIpFYHps2QKlmqz42TWRD GVDP1rFoDAN7mzkZO1ZA1X7L5J6hkJr7Bo5kAw2pAQJUy1UZaETZ90rrzIg25V+synar Mw4g+vo1dNSVP5eSuUeH9s7PQ0zWdzZ7LWkv/RYocgOK3Pg/OO3zHuZQlAEbbKjiJvQP 4s0A== X-Gm-Message-State: APjAAAWzncjYzi/wEKDwiiLeLbReDzVE12z4a7uX9cRxSGZmvEJ8dU8B i1ZVTdUhjtYtmJ74G8LtCApF6A== X-Google-Smtp-Source: APXvYqxdJaq+tjqwlkNjA3yZxE27RrcB8vklN/vHDwlCT/UHbutDytwO22j88xr0XdUHcUWuaHtViw== X-Received: by 2002:adf:f308:: with SMTP id i8mr18345662wro.42.1579530833941; Mon, 20 Jan 2020 06:33:53 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id u1sm970578wmc.5.2020.01.20.06.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 06:33:52 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 537D71FF87; Mon, 20 Jan 2020 14:33:52 +0000 (GMT) References: <20200109024907.2730-1-richard.henderson@linaro.org> <20200109024907.2730-9-richard.henderson@linaro.org> User-agent: mu4e 1.3.6; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Richard Henderson Subject: Re: [PATCH 8/9] cputlb: Initialize tlbs as flushed In-reply-to: <20200109024907.2730-9-richard.henderson@linaro.org> Date: Mon, 20 Jan 2020 14:33:52 +0000 Message-ID: <87zhei19kf.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair.francis@wdc.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Richard Henderson writes: > There's little point in leaving these data structures half initialized, > and relying on a flush to be done during reset. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e > --- > accel/tcg/cputlb.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c > index c7c34b185b..761e9d44d7 100644 > --- a/accel/tcg/cputlb.c > +++ b/accel/tcg/cputlb.c > @@ -240,6 +240,7 @@ static void tlb_mmu_init(CPUTLBDesc *desc, CPUTLBDesc= Fast *fast, int64_t now) > fast->mask =3D (n_entries - 1) << CPU_TLB_ENTRY_BITS; > fast->table =3D g_new(CPUTLBEntry, n_entries); > desc->iotlb =3D g_new(CPUIOTLBEntry, n_entries); > + tlb_mmu_flush_locked(desc, fast); > } >=20=20 > static inline void tlb_n_used_entries_inc(CPUArchState *env, uintptr_t m= mu_idx) > @@ -260,8 +261,8 @@ void tlb_init(CPUState *cpu) >=20=20 > qemu_spin_init(&env_tlb(env)->c.lock); >=20=20 > - /* Ensure that cpu_reset performs a full flush. */ > - env_tlb(env)->c.dirty =3D ALL_MMUIDX_BITS; > + /* All tlbs are initialized flushed. */ > + env_tlb(env)->c.dirty =3D 0; >=20=20 > for (i =3D 0; i < NB_MMU_MODES; i++) { > tlb_mmu_init(&env_tlb(env)->d[i], &env_tlb(env)->f[i], now); --=20 Alex Benn=C3=A9e