From: "Alex Bennée" <alex.bennee@linaro.org>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: qemu-devel@nongnu.org, lizhijian@cn.fujitsu.com,
jan.kiszka@siemens.com, jasowang@redhat.com, pbonzini@redhat.com,
stefanha@redhat.com, zhangckid@gmail.com
Subject: Re: [Qemu-devel] [PATCH] slirp: replace QEMU_BUILD_BUG_ON with G_STATIC_ASSERT
Date: Mon, 28 Jan 2019 11:07:32 +0000 [thread overview]
Message-ID: <87zhrlm45n.fsf@linaro.org> (raw)
In-Reply-To: <20190128103900.ea6nxhm45u4p5mpd@function>
Samuel Thibault <samuel.thibault@gnu.org> writes:
> Alex Bennée, le lun. 28 janv. 2019 10:35:37 +0000, a ecrit:
>> Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
>>
>> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>>
>> Is there a rationale as to why we should replace QEMU_BUILD_BUG_ON with
>> G_STATIC_ASSERT or is it particular to these QEMU_BUILD_BUG_ON
>> instances? It would be nice to have a little more context in the commit
>> message.
>
> It is yet more work towards moving slirp/ to a separately-maintained
> libslirp.
thanks, that makes more sense. If you could just mention that in the
commit it would save confusion about QEMU_BUILD_BUG_ON being deprecated
;-)
With that:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
prev parent reply other threads:[~2019-01-28 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 11:46 [Qemu-devel] [PATCH] slirp: replace QEMU_BUILD_BUG_ON with G_STATIC_ASSERT Samuel Thibault
2019-01-27 12:02 ` Marc-André Lureau
2019-01-27 19:11 ` Richard Henderson
2019-01-28 8:31 ` Stefano Garzarella
2019-01-28 10:35 ` Alex Bennée
2019-01-28 10:39 ` Samuel Thibault
2019-01-28 11:07 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhrlm45n.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@gnu.org \
--cc=stefanha@redhat.com \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).