qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, amit.shah@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] migration: report an error giving the failed field
Date: Wed, 05 Oct 2016 10:49:11 +0200	[thread overview]
Message-ID: <87zimjw588.fsf@emacs.mitica> (raw)
In-Reply-To: <1475002565-30170-2-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Tue, 27 Sep 2016 19:56:04 +0100")

"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> When a field fails to load (typically due to a limit
> check, or a call to a get/put) report the device and field
> to give an indication of the cause.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>  migration/vmstate.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/migration/vmstate.c b/migration/vmstate.c
> index fc29acf..1d637b2 100644
> --- a/migration/vmstate.c
> +++ b/migration/vmstate.c
> @@ -130,6 +130,8 @@ int vmstate_load_state(QEMUFile *f, const VMStateDescription *vmsd,
>                  }
>                  if (ret < 0) {
>                      qemu_file_set_error(f, ret);
> +                    error_report("Failed to load %s:%s", vmsd->name,
> +                                 field->name);
>                      trace_vmstate_load_field_error(field->name, ret);
>                      return ret;
>                  }

Applied, thanks.

  reply	other threads:[~2016-10-05  8:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-27 18:56 [Qemu-devel] [PATCH 0/2] Add error reporting in migration Dr. David Alan Gilbert (git)
2016-09-27 18:56 ` [Qemu-devel] [PATCH 1/2] migration: report an error giving the failed field Dr. David Alan Gilbert (git)
2016-10-05  8:49   ` Juan Quintela [this message]
2016-09-27 18:56 ` [Qemu-devel] [PATCH 2/2] migration: Report values for comparisons Dr. David Alan Gilbert (git)
2016-10-05  8:49   ` Juan Quintela
2016-09-27 21:22 ` [Qemu-devel] [PATCH 0/2] Add error reporting in migration John Snow
2016-09-28  2:16   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zimjw588.fsf@emacs.mitica \
    --to=quintela@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).