From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34624)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1brhtD-0004zg-JG
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 04:49:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1brht7-0002tD-M3
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 04:49:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49756)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1brht7-0002sS-Fw
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 04:49:17 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id F105E633EE
	for <qemu-devel@nongnu.org>; Wed,  5 Oct 2016 08:49:15 +0000 (UTC)
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1475002565-30170-2-git-send-email-dgilbert@redhat.com> (David
	Alan Gilbert's message of "Tue, 27 Sep 2016 19:56:04 +0100")
References: <1475002565-30170-1-git-send-email-dgilbert@redhat.com>
	<1475002565-30170-2-git-send-email-dgilbert@redhat.com>
Reply-To: quintela@redhat.com
Date: Wed, 05 Oct 2016 10:49:11 +0200
Message-ID: <87zimjw588.fsf@emacs.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 1/2] migration: report an error giving the
 failed field
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, amit.shah@redhat.com

"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> When a field fails to load (typically due to a limit
> check, or a call to a get/put) report the device and field
> to give an indication of the cause.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>  migration/vmstate.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/migration/vmstate.c b/migration/vmstate.c
> index fc29acf..1d637b2 100644
> --- a/migration/vmstate.c
> +++ b/migration/vmstate.c
> @@ -130,6 +130,8 @@ int vmstate_load_state(QEMUFile *f, const VMStateDescription *vmsd,
>                  }
>                  if (ret < 0) {
>                      qemu_file_set_error(f, ret);
> +                    error_report("Failed to load %s:%s", vmsd->name,
> +                                 field->name);
>                      trace_vmstate_load_field_error(field->name, ret);
>                      return ret;
>                  }

Applied, thanks.