From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boRLi-0000lo-U4 for qemu-devel@nongnu.org; Mon, 26 Sep 2016 04:33:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boRLe-0005gX-TH for qemu-devel@nongnu.org; Mon, 26 Sep 2016 04:33:18 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:35088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boRLe-0005fL-O8 for qemu-devel@nongnu.org; Mon, 26 Sep 2016 04:33:14 -0400 Received: by mail-wm0-f41.google.com with SMTP id l132so138385794wmf.0 for ; Mon, 26 Sep 2016 01:33:14 -0700 (PDT) References: <1474644551-5819-1-git-send-email-rth@twiddle.net> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1474644551-5819-1-git-send-email-rth@twiddle.net> Date: Mon, 26 Sep 2016 09:32:12 +0100 Message-ID: <87zimvf4dv.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/4] target-cris: Do not dump cpu state with -d in_asm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, "Edgar E . Iglesias" Richard Henderson writes: > Dumping cpu state is what -d cpu is for. > > Cc: Edgar E. Iglesias > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target-cris/translate.c | 25 ++----------------------- > 1 file changed, 2 insertions(+), 23 deletions(-) > > diff --git a/target-cris/translate.c b/target-cris/translate.c > index f4a8d7d..9de26af 100644 > --- a/target-cris/translate.c > +++ b/target-cris/translate.c > @@ -3135,29 +3135,6 @@ void gen_intermediate_code(CPUCRISState *env, struct TranslationBlock *tb) > > dc->cpustate_changed = 0; > > - if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) { > - qemu_log( > - "pc=%x %x flg=%" PRIx64 " bt=%x ds=%u ccs=%x\n" > - "pid=%x usp=%x\n" > - "%x.%x.%x.%x\n" > - "%x.%x.%x.%x\n" > - "%x.%x.%x.%x\n" > - "%x.%x.%x.%x\n", > - dc->pc, dc->ppc, > - (uint64_t)tb->flags, > - env->btarget, (unsigned)tb->flags & 7, > - env->pregs[PR_CCS], > - env->pregs[PR_PID], env->pregs[PR_USP], > - env->regs[0], env->regs[1], env->regs[2], env->regs[3], > - env->regs[4], env->regs[5], env->regs[6], env->regs[7], > - env->regs[8], env->regs[9], > - env->regs[10], env->regs[11], > - env->regs[12], env->regs[13], > - env->regs[14], env->regs[15]); > - qemu_log("--------------\n"); > - qemu_log("IN: %s\n", lookup_symbol(pc_start)); > - } > - > next_page_start = (pc_start & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE; > num_insns = 0; > max_insns = tb->cflags & CF_COUNT_MASK; > @@ -3313,6 +3290,8 @@ void gen_intermediate_code(CPUCRISState *env, struct TranslationBlock *tb) > #if !DISAS_CRIS > if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) > && qemu_log_in_addr_range(pc_start)) { > + qemu_log("--------------\n"); > + qemu_log("IN: %s\n", lookup_symbol(pc_start)); > log_target_disas(cs, pc_start, dc->pc - pc_start, > env->pregs[PR_VR]); > qemu_log("\nisize=%d osize=%d\n", -- Alex Bennée