From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59809)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1axuTk-00088S-HY
	for qemu-devel@nongnu.org; Wed, 04 May 2016 06:56:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1axuTY-0001MX-W6
	for qemu-devel@nongnu.org; Wed, 04 May 2016 06:56:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58717)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1axuTY-0001Jb-Qz
	for qemu-devel@nongnu.org; Wed, 04 May 2016 06:56:16 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id A653A345583
	for <qemu-devel@nongnu.org>; Wed,  4 May 2016 10:56:05 +0000 (UTC)
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1461751518-12128-10-git-send-email-berrange@redhat.com> (Daniel
	P. Berrange's message of "Wed, 27 Apr 2016 11:04:59 +0100")
References: <1461751518-12128-1-git-send-email-berrange@redhat.com>
	<1461751518-12128-10-git-send-email-berrange@redhat.com>
Reply-To: quintela@redhat.com
Date: Wed, 04 May 2016 12:56:02 +0200
Message-ID: <87zis6f5x9.fsf@emacs.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v6 for-2.7 09/28] migration: add helpers
 for creating QEMUFile from a QIOChannel
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Amit Shah <amit.shah@redhat.com>

"Daniel P. Berrange" <berrange@redhat.com> wrote:
> Currently creating a QEMUFile instance from a QIOChannel is
> quite simple only requiring a single call to
> qemu_fopen_channel_input or  qemu_fopen_channel_output
> depending on the end of migration connection.
>
> When QEMU gains TLS support, however, there will need to be
> a TLS negotiation done inbetween creation of the QIOChannel
> and creation of the final QEMUFile. Introduce some helper
> methods that will encapsulate this logic, isolating the
> migration protocol drivers from knowledge about TLS.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

Acked-by: Juan Quintela <quintela@redhat.com>