* [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-posix-acl: Fix out-of-bounds access
@ 2015-03-13 5:48 Shannon Zhao
2015-03-13 8:31 ` Aneesh Kumar K.V
0 siblings, 1 reply; 3+ messages in thread
From: Shannon Zhao @ 2015-03-13 5:48 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, hangaohuai, qemu-trivial, mjt, peter.huangpeng,
aneesh.kumar, pbonzini, shannon.zhao
It's detected by coverity. Fix out-of-bounds access of the function mp_dacl_listxattr.
Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
---
hw/9pfs/virtio-9p-posix-acl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/9pfs/virtio-9p-posix-acl.c b/hw/9pfs/virtio-9p-posix-acl.c
index 803d9d9..09dad07 100644
--- a/hw/9pfs/virtio-9p-posix-acl.c
+++ b/hw/9pfs/virtio-9p-posix-acl.c
@@ -114,7 +114,7 @@ static ssize_t mp_dacl_listxattr(FsContext *ctx, const char *path,
}
/* len includes the trailing NUL */
- memcpy(value, ACL_ACCESS, len);
+ memcpy(value, ACL_DEFAULT, len);
return 0;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-posix-acl: Fix out-of-bounds access
2015-03-13 5:48 [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-posix-acl: Fix out-of-bounds access Shannon Zhao
@ 2015-03-13 8:31 ` Aneesh Kumar K.V
2015-03-13 9:43 ` Shannon Zhao
0 siblings, 1 reply; 3+ messages in thread
From: Aneesh Kumar K.V @ 2015-03-13 8:31 UTC (permalink / raw)
To: Shannon Zhao, qemu-devel
Cc: peter.maydell, hangaohuai, qemu-trivial, mjt, peter.huangpeng,
shannon.zhao, pbonzini
Shannon Zhao <zhaoshenglong@huawei.com> writes:
> It's detected by coverity. Fix out-of-bounds access of the function mp_dacl_listxattr.
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> hw/9pfs/virtio-9p-posix-acl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/9pfs/virtio-9p-posix-acl.c b/hw/9pfs/virtio-9p-posix-acl.c
> index 803d9d9..09dad07 100644
> --- a/hw/9pfs/virtio-9p-posix-acl.c
> +++ b/hw/9pfs/virtio-9p-posix-acl.c
> @@ -114,7 +114,7 @@ static ssize_t mp_dacl_listxattr(FsContext *ctx, const char *path,
> }
>
> /* len includes the trailing NUL */
> - memcpy(value, ACL_ACCESS, len);
> + memcpy(value, ACL_DEFAULT, len);
> return 0;
> }
Applied.
Thanks
-aneesh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-posix-acl: Fix out-of-bounds access
2015-03-13 8:31 ` Aneesh Kumar K.V
@ 2015-03-13 9:43 ` Shannon Zhao
0 siblings, 0 replies; 3+ messages in thread
From: Shannon Zhao @ 2015-03-13 9:43 UTC (permalink / raw)
To: Aneesh Kumar K.V, qemu-devel
Cc: peter.maydell, hangaohuai, qemu-trivial, mjt, peter.huangpeng,
shannon.zhao, pbonzini
On 2015/3/13 16:31, Aneesh Kumar K.V wrote:
> Shannon Zhao <zhaoshenglong@huawei.com> writes:
>
>> It's detected by coverity. Fix out-of-bounds access of the function mp_dacl_listxattr.
>>
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>> hw/9pfs/virtio-9p-posix-acl.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/9pfs/virtio-9p-posix-acl.c b/hw/9pfs/virtio-9p-posix-acl.c
>> index 803d9d9..09dad07 100644
>> --- a/hw/9pfs/virtio-9p-posix-acl.c
>> +++ b/hw/9pfs/virtio-9p-posix-acl.c
>> @@ -114,7 +114,7 @@ static ssize_t mp_dacl_listxattr(FsContext *ctx, const char *path,
>> }
>>
>> /* len includes the trailing NUL */
>> - memcpy(value, ACL_ACCESS, len);
>> + memcpy(value, ACL_DEFAULT, len);
>> return 0;
>> }
>
> Applied.
>
Thanks :-)
> Thanks
> -aneesh
>
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-13 9:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-13 5:48 [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-posix-acl: Fix out-of-bounds access Shannon Zhao
2015-03-13 8:31 ` Aneesh Kumar K.V
2015-03-13 9:43 ` Shannon Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).