From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz4T9-0006N6-93 for qemu-devel@nongnu.org; Tue, 16 Jul 2013 08:35:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uz4T3-0006Tx-Vt for qemu-devel@nongnu.org; Tue, 16 Jul 2013 08:35:03 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:32870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz4T3-0006Ta-PE for qemu-devel@nongnu.org; Tue, 16 Jul 2013 08:34:57 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Jul 2013 06:34:57 -0600 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 3C0D46E8028 for ; Tue, 16 Jul 2013 08:34:49 -0400 (EDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6GCYrLb094390 for ; Tue, 16 Jul 2013 08:34:53 -0400 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6GCYqST007247 for ; Tue, 16 Jul 2013 06:34:53 -0600 From: Anthony Liguori In-Reply-To: <20130716105432.0415d563@gondolin> References: <1373903207-27085-1-git-send-email-cornelia.huck@de.ibm.com> <874nbvsr3d.fsf@codemonkey.ws> <51E42E4B.1090604@redhat.com> <20130716071041.GA30636@stefanha-thinkpad.redhat.com> <20130716105432.0415d563@gondolin> Date: Tue, 16 Jul 2013 07:34:47 -0500 Message-ID: <87zjtmd6oo.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PULL] virtio-ccw: dataplane enablement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Stefan Hajnoczi Cc: Blue Swirl , Paolo Bonzini , =?utf-8?Q?Aur=C3=A9lien?= Jarno , qemu-devel , Stefan Hajnoczi Cornelia Huck writes: > On Tue, 16 Jul 2013 15:10:41 +0800 > Stefan Hajnoczi wrote: > >> > Considering what the patch looks like, I don't think it's a huge >> > problem... In fact, perhaps x-data-plane could be even added to >> > DEFINE_VIRTIO_BLK_PROPERTIES. This would make it clear that support for >> > non-ioeventfd hosts (including TCG) is one of the things to do to make >> > data plane the default. >> >> I agree. Since this patch is so minimal it will not add extra work as >> we reintegrate dataplane into core QEMU. >> >> Acked-by: Stefan Hajnoczi >> > Thank you. > > Any further guidelines on when to ask for acks from you guys? Three days between a post and pull request is a bit short especially with no feedback. That was my primary concern here. Regards, Anthony Liguori > The mode > I've been operating in is mostly "if virtio-pci provides this feature, > it shouldn't be half bad and we want it in virtio-ccw as well in order > to keep things consistent and get more test coverage". > > (dataplane has been enabled in our internal testing for some time now, > I just had asked Dominik to re-do his patch with a proper description > as we had some code churn in our internal repository.)