From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uqs1c-0001ZX-EG for qemu-devel@nongnu.org; Sun, 23 Jun 2013 17:40:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uqs1b-0005gS-Dh for qemu-devel@nongnu.org; Sun, 23 Jun 2013 17:40:44 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:39046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uqs1b-0005Ke-7w for qemu-devel@nongnu.org; Sun, 23 Jun 2013 17:40:43 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 23 Jun 2013 17:39:59 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 221D8C9003E for ; Sun, 23 Jun 2013 17:39:56 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5NLdu2n326458 for ; Sun, 23 Jun 2013 17:39:56 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5NLdueB025592 for ; Sun, 23 Jun 2013 18:39:56 -0300 From: Anthony Liguori In-Reply-To: <1372018066-21822-1-git-send-email-mail@kevin-wolf.de> References: <1372018066-21822-1-git-send-email-mail@kevin-wolf.de> Date: Sun, 23 Jun 2013 16:39:53 -0500 Message-ID: <87zjugwlp2.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 0/3] multiboot: Fix memory information List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com Kevin Wolf writes: > Kevin Wolf (3): > multiboot: Don't forget last mmap entry > multiboot: Calculate upper_mem in the ROM > multiboot: Updated ROM binary Reviewed-by: Anthony Liguori Do you have a test case that triggered this that you can share? I'll apply this after a day or so when others have had a chance to review. Regards, Anthony Liguori > > hw/i386/multiboot.c | 2 - > pc-bios/multiboot.bin | Bin 1024 -> 1024 bytes > pc-bios/optionrom/multiboot.S | 75 +++++++++++++++++++++++++++++++---------- > 3 files changed, 57 insertions(+), 20 deletions(-) > mode change 100644 => 100755 pc-bios/multiboot.bin > > -- > 1.7.7