Re: [Qemu-devel] [PATCH 0/6] migration: followups for writev patches

[Anthony Liguori <anthony@codemonkey.ws>]

Orit Wasserman <owasserm@redhat.com> writes:

> On 03/27/2013 06:36 PM, Paolo Bonzini wrote:
>> This series fixes a few small problems in Orit's writev patches:
>> 
>> 1) socket_put_buffer is not needed anymore and can be dropped (patch 1);
>> 
>> 2) sendmsg could do a partial write even for a blocking socket, in
>> case it is interrupted by a signal. This should not happen for
>> migration, but it is relatively easy to fix in iov_send_recv (patches
>> 2 to 5);
>> 
>> 3) recent libvirt will always use fd migration, and thus will not
>> benefit from the writev speedups.  fd migration also uses FILE*, which
>> incurs an extra copy.  Patch 6 fixes both issues.
>> 
>> Thanks,
>> 
>> Paolo
>> 
>> Paolo Bonzini (6):
>>   qemu-file: drop socket_put_buffer
>>   iov: reorganize iov_send_recv, part 1
>>   iov: reorganize iov_send_recv, part 2
>>   iov: reorganize iov_send_recv, part 3
>>   iov: handle partial writes from sendmsg and recvmsg
>>   qemu-file: do not use stdio for qemu_fdopen
>> 
>>  savevm.c   | 113 ++++++++++++++++++++++++++++++++++++++++++++++++-------------
>>  util/iov.c | 104 ++++++++++++++++++++++++++++++++------------------------
>>  2 files changed, 148 insertions(+), 69 deletions(-)
>> 
> Series
> Reviewed-by: Orit Wasserman <owasserm@redhat.com>

Per Paolo, I will process this through my queue.

Regards,

Anthony Liguori